Sign upLogin

archivesspace/archivesspace

View on GitHub
Star
indexer/app/lib/periodic_indexer.rb

Summary

Maintainability
D
2 days
Test Coverage

Method start_worker_thread has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

  def start_worker_thread(queue, record_type)
    repo_id = JSONModel.repository
    session = JSONModel::HTTP.current_backend_session

    Thread.new do
Severity: Minor
Found in indexer/app/lib/periodic_indexer.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_index_round has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

  def run_index_round
    log("Running index round")

    login
Severity: Minor
Found in indexer/app/lib/periodic_indexer.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start_worker_thread has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def start_worker_thread(queue, record_type)
    repo_id = JSONModel.repository
    session = JSONModel::HTTP.current_backend_session

    Thread.new do
Severity: Major
Found in indexer/app/lib/periodic_indexer.rb - About 2 hrs to fix

    Method run_index_round has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run_index_round
    log("Running index round")

    login
    Severity: Major
    Found in indexer/app/lib/periodic_indexer.rb - About 2 hrs to fix

      Method handle_deletes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def handle_deletes(opts = {})
    start = Time.now
    last_mtime = @state.get_last_mtime('_deletes', 'deletes')
    did_something = false
      Severity: Minor
      Found in indexer/app/lib/periodic_indexer.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    while true
      begin
        run_index_round unless paused?
      rescue
      Severity: Minor
      Found in indexer/app/lib/periodic_indexer.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status