archivesspace/archivesspace

View on GitHub
reports/resources/resource_instances_subreport/resource_instances_subreport.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method query_string has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def query_string
    "select distinct
      top_container.id as top_container_id,
      top_container.type_id as type_1,
      top_container.indicator as indicator_1,

    Method query has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def query
        results = db.fetch(query_string)
        sorted = {}
        results.each do |result|
          top_id = result[:top_container_id]

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method query_profiles has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def query_profiles(container_id)
        query_string = "select name from
        container_profile join top_container_profile_rlshp
          on container_profile.id = container_profile_id
        where top_container_id = #{db.literal(container_id)}"

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

      def query
        results = db.fetch(query_string)
        sorted = {}
        results.each do |result|
          top_id = result[:top_container_id]
    reports/accessions/accession_instances_subreport/accession_instances_subreport.rb on lines 10..35
    reports/resources/archival_object_instances_subreport/archival_object_instances_subreport.rb on lines 10..35

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      def query_profiles(container_id)
        query_string = "select name from
        container_profile join top_container_profile_rlshp
          on container_profile.id = container_profile_id
        where top_container_id = #{db.literal(container_id)}"
    reports/accessions/accession_instances_subreport/accession_instances_subreport.rb on lines 85..99
    reports/locations/location_containers_subreport/location_containers_subreport.rb on lines 28..42
    reports/resources/archival_object_instances_subreport/archival_object_instances_subreport.rb on lines 86..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      def fix_row(row)
        row[:instances].each do |instance|
          ReportUtils.get_enum_values(instance, [:type_2, :type_3, :instance_type])
          ReportUtils.fix_container_indicator(instance, 2)
          ReportUtils.fix_container_indicator(instance, 3)
    reports/resources/archival_object_instances_subreport/archival_object_instances_subreport.rb on lines 75..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status