Sign upLogin

arichr/gophient

View on GitHub
Star

Showing 18 of 18 total issues

Cyclomatic complexity is too high in method parse_response. (7)
Open

    def parse_response(self, resp: 'ResponseType') -> Union[List[Item], 'ResponseType']:
        """Parse the server response.

        Args:
            resp (ResponseType): Server response
Severity: Minor
Found in gophient/types.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function parse_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_response(self, resp: 'ResponseType') -> Union[List[Item], 'ResponseType']:
        """Parse the server response.

        Args:
            resp (ResponseType): Server response
Severity: Minor
Found in gophient/types.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (88 > 79 characters)
Open

    def parse_response(self, resp: 'ResponseType') -> Union[List[Item], 'ResponseType']:
Severity: Minor
Found in gophient/types.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (86 > 79 characters)
Open

    """The IP address or the domain name of a server that this item is pointing to."""
Severity: Minor
Found in gophient/types.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (84 > 79 characters)
Open

        self, host: str, path: str = '/', port: int = 70, query: 'RequestType' = '',
Severity: Minor
Found in gophient/types.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (81 > 79 characters)
Open

    def parse(cls, client: 'Gopher', raw: 'ResponseType') -> Union['Item', None]:
Severity: Minor
Found in gophient/types.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (91 > 79 characters)
Open

        return f'{self.desc} ({self.pretty_type}) - {self.path} on {self.host}:{self.port}'
Severity: Minor
Found in gophient/types.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (81 > 79 characters)
Open

    """The human-readable item type. Possible values are `const.TYPES` values."""
Severity: Minor
Found in gophient/types.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (80 > 79 characters)
Open

            enc_query = urllib.parse.quote(query, safe='').encode(self.encoding)
Severity: Minor
Found in gophient/types.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (91 > 79 characters)
Open

        return self._client.request(self.host, self.path, self.port, self._client.encoding)
Severity: Minor
Found in gophient/types.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert isinstance(resp, list)
Severity: Info
Found in tests/test_gopher.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert resp
Severity: Info
Found in tests/test_gopher.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert isinstance(resp, bytes)
Severity: Info
Found in tests/test_gopher.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert resp[0].pretty_type == 'Informational message'
Severity: Info
Found in tests/test_gopher.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert resp and new_resp and resp != new_resp
Severity: Info
Found in tests/test_gopher.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert isinstance(resp, list)
Severity: Info
Found in tests/test_gopher.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert isinstance(resp, list)
    # We combine informational messages if they are placed together.
    # In that case resp[1] is guranteed to be a link.
Severity: Info
Found in tests/test_gopher.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

    assert '?cat forward=' in resp[-1].path
Severity: Info
Found in tests/test_gopher.py by bandit
Severity
Category
Status
Source
Language