Sign upLogin

aristath/kirki

View on GitHub
Star

Showing 644 of 644 total issues

Function calculateImageSelectOptions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    calculateImageSelectOptions: function( attachment, controller ) {
        var control    = controller.get( 'control' ),
            flexWidth  = !! parseInt( control.params.flex_width, 10 ),
            flexHeight = !! parseInt( control.params.flex_height, 10 ),
            realWidth  = attachment.get( 'width' ),
Severity: Minor
Found in packages/kirki-framework/control-repeater/src/control.js - About 1 hr to fix

Method generate_controls_group has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function generate_controls_group( $group, $args ) {

        $total_specified = 0;
        $field_width     = 100;
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 1 hr to fix

Method process_output has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function process_output( $output, $value ) {

        $output['media_query'] = ( isset( $output['media_query'] ) ) ? $output['media_query'] : 'global';
        $output['element']     = ( isset( $output['element'] ) ) ? $output['element'] : 'body';
        $output['prefix']      = ( isset( $output['prefix'] ) ) ? $output['prefix'] : '';
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/CSS/Typography.php - About 1 hr to fix

Function exports has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (Base, NAME, Constructor, next, DEFAULT, IS_SET, FORCED) {
  $iterCreate(Constructor, NAME, next);
  var getMethod = function (kind) {
    if (!BUGGY && kind in proto) return proto[kind];
    switch (kind) {
Severity: Minor
Found in packages/kirki-framework/compatibility/src/scripts/wp-polyfill.js - About 1 hr to fix

Function packIEEE754 has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function packIEEE754(value, mLen, nBytes) {
  var buffer = new Array(nBytes);
  var eLen = nBytes * 8 - mLen - 1;
  var eMax = (1 << eLen) - 1;
  var eBias = eMax >> 1;
Severity: Minor
Found in packages/kirki-framework/compatibility/src/scripts/wp-polyfill.js - About 1 hr to fix

Function maybeInvokeDelegate has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function maybeInvokeDelegate(delegate, context) {
    var method = delegate.iterator[context.method];
    if (method === undefined) {
      // A .throw or .return when the delegate iterator has no .throw
      // method always terminates the yield* loop.
Severity: Minor
Found in packages/kirki-framework/compatibility/src/scripts/wp-polyfill.js - About 1 hr to fix

Function notify has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var notify = function (promise, isReject) {
  if (promise._n) return;
  promise._n = true;
  var chain = promise._c;
  microtask(function () {
Severity: Minor
Found in packages/kirki-framework/compatibility/src/scripts/wp-polyfill.js - About 1 hr to fix

Function 75 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

},{"101":101,"16":16,"37":37,"38":38,"49":49,"76":76}],75:[function(_dereq_,module,exports){
var anObject = _dereq_(16);
var IE8_DOM_DEFINE = _dereq_(50);
var toPrimitive = _dereq_(119);
var dP = Object.defineProperty;
Severity: Minor
Found in packages/kirki-framework/compatibility/src/scripts/wp-polyfill.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function 112 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

},{}],112:[function(_dereq_,module,exports){
var ctx = _dereq_(32);
var invoke = _dereq_(52);
var html = _dereq_(49);
var cel = _dereq_(37);
Severity: Minor
Found in packages/kirki-framework/compatibility/src/scripts/wp-polyfill.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function 210 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

},{"11":11,"16":16,"40":40,"42":42,"46":46}],210:[function(_dereq_,module,exports){
// 26.1.2 Reflect.construct(target, argumentsList [, newTarget])
var $export = _dereq_(40);
var create = _dereq_(74);
var aFunction = _dereq_(11);
Severity: Minor
Found in packages/kirki-framework/compatibility/src/scripts/wp-polyfill.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function KirkiReactColorfulInput has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

const KirkiReactColorfulInput = (props) => {
  const { onChange, color = "" } = props;
  const [value, setValue] = useState(() => color);

  const handleChange = useCallback(
Severity: Minor
Found in packages/kirki-framework/control-react-colorful/src/js/components/KirkiReactColorfulInput.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function useClickOutside has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

const useClickOutside = (pickerRef, resetRef, handler) => {
  useEffect(() => {
    let startedWhenMounted = false;
    let startedInside = false;
Severity: Minor
Found in packages/kirki-framework/control-react-colorful/src/js/hooks/useClickOutside.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init_filesystem has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public static function init_filesystem() {
        $credentials = [];

        if ( ! defined( 'FS_METHOD' ) ) {
            define( 'FS_METHOD', 'direct' );
Severity: Minor
Found in packages/kirki-framework/util/src/Helper.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function migrate_css_vars has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private static function migrate_css_vars( $args ) {
        // Convert css_vars to output args.
        if ( isset( $args['css_vars'] ) ) {

            if ( 'postMessage' === $args['transport'] ) {
Severity: Minor
Found in packages/kirki-framework/compatibility/src/Kirki.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function process_value has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    protected function process_value() {
        $this->value = trim( $this->value );

        // If you use calc() there, I suppose you know what you're doing.
        // No need to process this any further, just exit.
Severity: Minor
Found in packages/kirki-framework/module-css/src/CSS/Property/Background_Position.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function kirki_get_value has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function kirki_get_value( $value = '', $option = '', $default = '', $type = 'theme_mod' ) {
        if ( 'option' === $type ) {

            /**
             * If the option doesn't contain a '[', then it's not a sub-item
Severity: Minor
Found in packages/kirki-framework/data-option/src/Option.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function enqueue_control_scripts has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function enqueue_control_scripts() {

        wp_enqueue_style( 'kirki-control-typography', \Kirki\URL::get_from_path( dirname( dirname( __DIR__ ) ) . '/dist/control.css' ), [], '1.0' );

        wp_enqueue_script( 'kirki-control-typography', \Kirki\URL::get_from_path( dirname( dirname( __DIR__ ) ) . '/dist/control.js' ), [], '1.0', true );
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function 70 has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

},{}],70:[function(_dereq_,module,exports){
var META = _dereq_(123)('meta');
var isObject = _dereq_(57);
var has = _dereq_(47);
var setDesc = _dereq_(75).f;
Severity: Minor
Found in packages/kirki-framework/compatibility/src/scripts/wp-polyfill.js - About 1 hr to fix

Method add_prefixes has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function add_prefixes( $css ) {
        if ( is_array( $css ) ) {
            foreach ( $css as $media_query => $elements ) {
                foreach ( $elements as $element => $style_array ) {
                    foreach ( $style_array as $property => $value ) {
Severity: Minor
Found in packages/kirki-framework/module-css/src/CSS/Generator.php - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function filter_setting_args( $args, $wp_customize ) {

        if ( $args['settings'] === $this->args['settings'] ) {
            $args = parent::filter_setting_args( $args, $wp_customize );
Severity: Major
Found in packages/kirki-framework/control-generic/src/Field/Number.php and 1 other location - About 1 hr to fix
packages/kirki-framework/control-slider/src/Field/Slider.php on lines 56..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language