Sign upLogin

aristath/kirki

View on GitHub
Star
packages/kirki-framework/field-typography/src/Field/Typography.php

Summary

Maintainability
F
5 days
Test Coverage

File Typography.php has 529 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Override field methods
 *
 * @package   kirki-framework/control-typography
Severity: Major
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 1 day to fix

Method add_sub_fields has 192 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function add_sub_fields( $args ) {

        $args['kirki_config'] = isset( $args['kirki_config'] ) ? $args['kirki_config'] : 'global';

        $defaults = isset( $args['default'] ) ? $args['default'] : [];
Severity: Major
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 7 hrs to fix

Method init has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function init( $args = [] ) {

        self::$typography_controls[] = $args['settings'];

        self::$std_variants = [
Severity: Major
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 3 hrs to fix

Function get_font_family_choices has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    private function get_font_family_choices() {

        $args = $this->args;

        // Figure out how to sort the fonts.
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_font_family_choices has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function get_font_family_choices() {

        $args = $this->args;

        // Figure out how to sort the fonts.
Severity: Major
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 2 hrs to fix

Function sanitize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public static function sanitize( $value ) {

        if ( ! is_array( $value ) ) {
            return [];
        }
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_controls_group has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function generate_controls_group( $group, $args ) {

        $total_specified = 0;
        $field_width     = 100;
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 1 hr to fix

Function enqueue_control_scripts has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function enqueue_control_scripts() {

        wp_enqueue_style( 'kirki-control-typography', \Kirki\URL::get_from_path( dirname( dirname( __DIR__ ) ) . '/dist/control.css' ), [], '1.0' );

        wp_enqueue_script( 'kirki-control-typography', \Kirki\URL::get_from_path( dirname( dirname( __DIR__ ) ) . '/dist/control.js' ), [], '1.0', true );
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sanitize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function sanitize( $value ) {

        if ( ! is_array( $value ) ) {
            return [];
        }
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 1 hr to fix

Method enqueue_control_scripts has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function enqueue_control_scripts() {

        wp_enqueue_style( 'kirki-control-typography', \Kirki\URL::get_from_path( dirname( dirname( __DIR__ ) ) . '/dist/control.css' ), [], '1.0' );

        wp_enqueue_script( 'kirki-control-typography', \Kirki\URL::get_from_path( dirname( dirname( __DIR__ ) ) . '/dist/control.js' ), [], '1.0', true );
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 1 hr to fix

Function add_sub_fields has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private function add_sub_fields( $args ) {

        $args['kirki_config'] = isset( $args['kirki_config'] ) ? $args['kirki_config'] : 'global';

        $defaults = isset( $args['default'] ) ? $args['default'] : [];
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generate_controls_group has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function generate_controls_group( $group, $args ) {

        $total_specified = 0;
        $field_width     = 100;
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function filter_preferred_choice_setting has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function filter_preferred_choice_setting( $setting, $choice, $args ) {

        // Fail early.
        if ( ! isset( $args[ $setting ] ) ) {
            return '';
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function filter_preferred_choice_setting( $setting, $choice, $args ) {

        // Fail early.
        if ( ! isset( $args[ $setting ] ) ) {
            return '';
Severity: Major
Found in packages/kirki-framework/field-typography/src/Field/Typography.php and 1 other location - About 2 hrs to fix
packages/kirki-framework/field-multicolor/src/Field/Multicolor.php on lines 115..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 138.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ( $margin_top_field_specified || $margin_bottom_field_specified ) {
            $group = [
                'margin-top'    => [
                    'type'         => 'dimension',
                    'label'        => esc_html__( 'Margin Top', 'kirki' ),
Severity: Major
Found in packages/kirki-framework/field-typography/src/Field/Typography.php and 1 other location - About 1 hr to fix
packages/kirki-framework/field-typography/src/Field/Typography.php on lines 373..394

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ( $line_height_field_specified || $letter_spacing_field_specified ) {
            $group = [
                'line-height'    => [
                    'type'         => 'dimension',
                    'label'        => esc_html__( 'Line Height', 'kirki' ),
Severity: Major
Found in packages/kirki-framework/field-typography/src/Field/Typography.php and 1 other location - About 1 hr to fix
packages/kirki-framework/field-typography/src/Field/Typography.php on lines 399..420

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    'choices'      => [
                        'none'         => esc_html__( 'None', 'kirki' ),
                        'underline'    => esc_html__( 'Underline', 'kirki' ),
                        'line-through' => esc_html__( 'Line Through', 'kirki' ),
                        'overline'     => esc_html__( 'Overline', 'kirki' ),
Severity: Minor
Found in packages/kirki-framework/field-typography/src/Field/Typography.php and 1 other location - About 45 mins to fix
example.php on lines 1143..1150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status