Sign upLogin

arkaitzgarro/elastic-apm-laravel

View on GitHub
Star

Showing 176 of 176 total issues

Method registerEventListeners has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function registerEventListeners(): void
    {
        $this->app->events->listen(JobProcessing::class, function (JobProcessing $event) {
            if ($this->app->runningInConsole()) {
                // Since the application starts only once for async queues, make sure
Severity: Minor
Found in src/Collectors/JobCollector.php - About 1 hr to fix

    Method registerEventListeners has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function registerEventListeners(): void
    {
        $this->app->events->listen(ScheduledTaskStarting::class, function (ScheduledTaskStarting $event) {
            $transaction_name = $this->getTransactionName($event);
            if ($transaction_name) {
    Severity: Minor
    Found in src/Collectors/ScheduledTaskCollector.php - About 1 hr to fix

      Method onQueryExecutedEvent has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function onQueryExecutedEvent(QueryExecuted $query): void
    {
        if ('auto' === $this->config->get('elastic-apm-laravel.spans.querylog.enabled')) {
            if ($query->time < $this->config->get('elastic-apm-laravel.spans.querylog.threshold')) {
                return;
      Severity: Minor
      Found in src/Collectors/DBQueryCollector.php - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                $transaction->setCustomContext([
            'ran_at' => Carbon::now()->toDateTimeString(),
            'memory' => [
                'peak' => round(memory_get_peak_usage(false) / 1024 / 1024, 2) . 'M',
                'peak_real' => round(memory_get_peak_usage(true) / 1024 / 1024, 2) . 'M',
        Severity: Major
        Found in src/Collectors/CommandCollector.php and 1 other location - About 1 hr to fix
        src/Collectors/ScheduledTaskCollector.php on lines 106..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                $transaction->setCustomContext([
            'ran_at' => Carbon::now()->toDateTimeString(),
            'memory' => [
                'peak' => round(memory_get_peak_usage(false) / 1024 / 1024, 2) . 'M',
                'peak_real' => round(memory_get_peak_usage(true) / 1024 / 1024, 2) . 'M',
        Severity: Major
        Found in src/Collectors/ScheduledTaskCollector.php and 1 other location - About 1 hr to fix
        src/Collectors/CommandCollector.php on lines 110..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        The parameter $app_config is not named in camelCase.
        Open

            public function withAppConfig(Repository $app_config): self
    {
        $this->app_config = $app_config;

        return $this;
        Severity: Minor
        Found in src/AgentBuilder.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $start_time is not named in camelCase.
        Open

            public function startMeasure(
        string $name,
        string $type = 'request',
        ?string $action = null,
        ?string $label = null,
        Severity: Minor
        Found in src/Collectors/EventDataCollector.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $transaction_name is not named in camelCase.
        Open

            protected function getTransaction(string $transaction_name): ?Transaction
    {
        try {
            return $this->agent->getTransaction($transaction_name);
        } catch (UnknownTransactionException $e) {
        Severity: Minor
        Found in src/Collectors/EventDataCollector.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The property $start_time is not named in camelCase.
        Open

        class RequestStartTime
{
    /**
     * @var float
     */
        Severity: Minor
        Found in src/Collectors/RequestStartTime.php by phpmd

        CamelCasePropertyName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name attributes.

        Example

        class ClassName {
    protected $property_name;
}

        Source

        The property $start_time is not named in camelCase.
        Open

        class StartMeasuring
{
    /** @var string */
    public $name;
        Severity: Minor
        Found in src/Events/StartMeasuring.php by phpmd

        CamelCasePropertyName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name attributes.

        Example

        class ClassName {
    protected $property_name;
}

        Source

        The parameter $transaction_name is not named in camelCase.
        Open

            protected function addMetadata(string $transaction_name, Job $job): void
    {
        $this->agent->getTransaction($transaction_name)->setCustomContext([
            'job_id' => $job->getJobId(),
            'max_tries' => $job->maxTries(),
        Severity: Minor
        Found in src/Collectors/JobCollector.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $transaction_name is not named in camelCase.
        Open

            protected function stopTransaction(string $transaction_name, ?int $result): void
    {
        // Stop the transaction and measure the time
        $this->agent->stopTransaction($transaction_name, ['result' => (int) $result]);
        $this->agent->collectEvents($transaction_name);
        Severity: Minor
        Found in src/Collectors/ScheduledTaskCollector.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The property $start_time is not named in camelCase.
        Open

        abstract class EventDataCollector implements DataCollector
{
    /** @var Application */
    protected $app;
        Severity: Minor
        Found in src/Collectors/EventDataCollector.php by phpmd

        CamelCasePropertyName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name attributes.

        Example

        class ClassName {
    protected $property_name;
}

        Source

        The property $event_clock is not named in camelCase.
        Open

        abstract class EventDataCollector implements DataCollector
{
    /** @var Application */
    protected $app;
        Severity: Minor
        Found in src/Collectors/EventDataCollector.php by phpmd

        CamelCasePropertyName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name attributes.

        Example

        class ClassName {
    protected $property_name;
}

        Source

        The parameter $transaction_name is not named in camelCase.
        Open

            protected function startTransaction(string $transaction_name): Transaction
    {
        return $this->agent->startTransaction(
            $transaction_name,
            [],
        Severity: Minor
        Found in src/Collectors/JobCollector.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $start_time is not named in camelCase.
        Open

            public function __construct(float $start_time)
    {
        $this->start_time = $start_time;
    }
        Severity: Minor
        Found in src/Collectors/RequestStartTime.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $start_time is not named in camelCase.
        Open

            final public function __construct(Application $app, Config $config, RequestStartTime $start_time, EventCounter $event_counter, EventClock $event_clock)
    {
        $this->app = $app;
        $this->config = $config;
        $this->start_time = $start_time;
        Severity: Minor
        Found in src/Collectors/EventDataCollector.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $transaction_name is not named in camelCase.
        Open

            protected function stopTransaction(string $transaction_name, int $result): void
    {
        // Stop the transaction and measure the time
        $this->agent->stopTransaction($transaction_name, ['result' => $result]);
        $this->agent->collectEvents($transaction_name);
        Severity: Minor
        Found in src/Collectors/CommandCollector.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $transaction_name is not named in camelCase.
        Open

            protected function stopTransaction(string $transaction_name, int $result): void
    {
        // Stop the transaction and measure the time
        $this->agent->stopTransaction($transaction_name, ['result' => $result]);
        $this->agent->collectEvents($transaction_name);
        Severity: Minor
        Found in src/Collectors/JobCollector.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $start_time is not named in camelCase.
        Open

            public function setStartTime(float $start_time): void
    {
        $this->start_time = $start_time;
    }
        Severity: Minor
        Found in src/Collectors/RequestStartTime.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        Severity
        Category
        Status
        Source
        Language