Sign upLogin

arkency/rails_event_store

View on GitHub
Star
contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb

Summary

Maintainability
D
2 days
Test Coverage

File event_repository.rb has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module RubyEventStore
  module Sequel
    class EventRepository
      UPSERT_COLUMNS = %i[event_type data metadata valid_at].freeze
Severity: Minor
Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 4 hrs to fix

    Class EventRepository has 29 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class EventRepository
      UPSERT_COLUMNS = %i[event_type data metadata valid_at].freeze

      def initialize(sequel:, serializer:)
        @serializer = serializer
    Severity: Minor
    Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 3 hrs to fix

      Method read_from_global_stream has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

            def read_from_global_stream(specification)
        dataset =
          @db[:event_store_events]
            .select(
              ::Sequel[:event_store_events][:event_id],
      Severity: Minor
      Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_from_specific_stream has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

            def read_from_specific_stream(specification)
        dataset =
          @db[:event_store_events]
            .join(:event_store_events_in_streams, event_id: :event_id)
            .select(
      Severity: Minor
      Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_from_specific_stream has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def read_from_specific_stream(specification)
        dataset =
          @db[:event_store_events]
            .join(:event_store_events_in_streams, event_id: :event_id)
            .select(
      Severity: Minor
      Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 1 hr to fix

        Method read_from_global_stream has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def read_from_global_stream(specification)
        dataset =
          @db[:event_store_events]
            .select(
              ::Sequel[:event_store_events][:event_id],
        Severity: Minor
        Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 1 hr to fix

          Method append_to_stream has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

                def append_to_stream(records, stream, expected_version)
        resolved_version = resolved_version(expected_version, stream)

        @db.transaction do
          records.map.with_index do |record, index|
          Severity: Minor
          Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method append_to_stream has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def append_to_stream(records, stream, expected_version)
        resolved_version = resolved_version(expected_version, stream)

        @db.transaction do
          records.map.with_index do |record, index|
          Severity: Minor
          Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 1 hr to fix

            Method read has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                  def read(specification)
        if specification.batched?
          stream = read_(specification)
          batch_reader = ->(offset, limit) { stream.offset(offset).limit(limit).map(&method(:record)) }
          RubyEventStore::BatchEnumerator.new(specification.batch_size, specification.limit, batch_reader).each
            Severity: Minor
            Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method link_to_stream has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                  def link_to_stream(event_ids, stream, expected_version)
        (
          event_ids -
            @db[:event_store_events]
              .select(::Sequel[:event_store_events][:event_id])
            Severity: Minor
            Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if specification.stop
          condition = "event_store_events_in_streams.id #{specification.forward? ? "<" : ">"} ?"
          dataset = dataset.where(::Sequel.lit(condition, find_event_id_in_stream(specification.stop, specification.stream.name)))
            Severity: Minor
            Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb and 1 other location - About 15 mins to fix
            contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb on lines 239..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if specification.start
          condition = "event_store_events_in_streams.id #{specification.forward? ? ">" : "<"} ?"
          dataset =
            dataset.where(::Sequel.lit(condition, find_event_id_in_stream(specification.start, specification.stream.name)))
            Severity: Minor
            Found in contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb and 1 other location - About 15 mins to fix
            contrib/ruby_event_store-sequel/lib/ruby_event_store/sequel/event_repository.rb on lines 245..247

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status