Sign upLogin

arkency/rails_event_store

View on GitHub
Star
ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb

Summary

Maintainability
D
1 day
Test Coverage

Method read_scope has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

      def read_scope(spec)
        if spec.stream.global?
          stream = @event_klass
          stream = stream.where(event_id: spec.with_ids) if spec.with_ids?
          stream = stream.where(event_type: spec.with_types) if spec.with_types?
Severity: Minor
Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class EventRepositoryReader has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

    class EventRepositoryReader
      def initialize(event_klass, stream_klass, serializer)
        @event_klass = event_klass
        @stream_klass = stream_klass
        @serializer = serializer
Severity: Minor
Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 3 hrs to fix

    Method read has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

          def read(spec)
        stream = read_scope(spec)
        if spec.batched?
          spec.time_sort_by ? offset_limit_batch_reader(spec, stream) : monotonic_id_batch_reader(spec, stream)
        elsif spec.first?
    Severity: Minor
    Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method read_scope has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def read_scope(spec)
        if spec.stream.global?
          stream = @event_klass
          stream = stream.where(event_id: spec.with_ids) if spec.with_ids?
          stream = stream.where(event_type: spec.with_types) if spec.with_types?
    Severity: Minor
    Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 1 hr to fix

      Method monotonic_id_batch_reader has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def monotonic_id_batch_reader(spec, stream)
        batch_reader = ->(offset_id, limit) do
          search_in = spec.stream.global? ? @event_klass.table_name : @stream_klass.table_name
          records =
            if offset_id.nil?
      Severity: Minor
      Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def start_condition(specification)
        start_offset_condition(
          specification,
          @stream_klass.find_by!(event_id: specification.start, stream: specification.stream.name),
          @stream_klass.table_name
      Severity: Minor
      Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb and 1 other location - About 15 mins to fix
      ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb on lines 154..161

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def stop_condition(specification)
        stop_offset_condition(
          specification,
          @stream_klass.find_by!(event_id: specification.stop, stream: specification.stream.name),
          @stream_klass.table_name
      Severity: Minor
      Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb and 1 other location - About 15 mins to fix
      ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb on lines 144..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status