Sign upLogin

armandofox/audience1st

View on GitHub
Star
app/controllers/donations_controller.rb

Summary

Maintainability
B
6 hrs
Test Coverage
C
72%

Method has too many lines. [47/30]
Open

  def index
    @total = 0
    @params = {}
    @page_title = "Donation history"
    @page = (params[:page] || '1').to_i
Severity: Minor
Found in app/controllers/donations_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for index is too high. [17/6]
Open

  def index
    @total = 0
    @params = {}
    @page_title = "Donation history"
    @page = (params[:page] || '1').to_i
Severity: Minor
Found in app/controllers/donations_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method index has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    @total = 0
    @params = {}
    @page_title = "Donation history"
    @page = (params[:page] || '1').to_i
Severity: Minor
Found in app/controllers/donations_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    @total = 0
    @params = {}
    @page_title = "Donation history"
    @page = (params[:page] || '1').to_i
Severity: Minor
Found in app/controllers/donations_controller.rb - About 1 hr to fix

    Method has too many lines. [31/30]
    Open

      def create
    @order = Order.create(:purchaser => @customer, :customer => @customer, :processed_by => current_user)
    @donation = Donation.from_amount_and_account_code_id(
      params[:amount].to_f, params[:fund].to_i, params[:comments].to_s)
    @order.add_donation(@donation)
    Severity: Minor
    Found in app/controllers/donations_controller.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method create has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create
    @order = Order.create(:purchaser => @customer, :customer => @customer, :processed_by => current_user)
    @donation = Donation.from_amount_and_account_code_id(
      params[:amount].to_f, params[:fund].to_i, params[:comments].to_s)
    @order.add_donation(@donation)
    Severity: Minor
    Found in app/controllers/donations_controller.rb - About 1 hr to fix

      Useless assignment to variable - e.
      Open

          rescue StandardError => e
      Severity: Minor
      Found in app/controllers/donations_controller.rb by rubocop

      This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

      assigned but unused variable - foo

      Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

      Example:

      # bad

def some_method
  some_var = 1
  do_something
end

      Example:

      # good

def some_method
  some_var = 1
  do_something(some_var)
end

      Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
      Open

          return redirect_to(donations_path, :alert => 'You must select a customer.') unless @customer = Customer.find(params[:customer_id])
      Severity: Minor
      Found in app/controllers/donations_controller.rb by rubocop

      This cop checks for assignments in the conditions of if/while/until.

      Example:

      # bad

if some_var = true
  do_something
end

      Example:

      # good

if some_var == true
  do_something
end

      There are no issues that match your filters.

      Category
      Status