Sign upLogin

armandofox/audience1st

View on GitHub
Star
app/controllers/orders_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage
B
87%

Cyclomatic complexity for update is too high. [14/6]
Open

  def update
    @order = Order.find params[:id]
    items = Item.find(params[:items].keys) rescue []
    if items.empty?
      redirect_to(order_path(@order), :alert => 'No items selected for refund.') and return
Severity: Minor
Found in app/controllers/orders_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [37/30]
Open

  def update
    @order = Order.find params[:id]
    items = Item.find(params[:items].keys) rescue []
    if items.empty?
      redirect_to(order_path(@order), :alert => 'No items selected for refund.') and return
Severity: Minor
Found in app/controllers/orders_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method update has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update
    @order = Order.find params[:id]
    items = Item.find(params[:items].keys) rescue []
    if items.empty?
      redirect_to(order_path(@order), :alert => 'No items selected for refund.') and return
Severity: Minor
Found in app/controllers/orders_controller.rb - About 1 hr to fix

    Method update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def update
    @order = Order.find params[:id]
    items = Item.find(params[:items].keys) rescue []
    if items.empty?
      redirect_to(order_path(@order), :alert => 'No items selected for refund.') and return
    Severity: Minor
    Found in app/controllers/orders_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          redirect_to(order_path(@order), :alert => "Error destroying order: #{e}") and return
    Severity: Major
    Found in app/controllers/orders_controller.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status