Sign upLogin

armandofox/audience1st

View on GitHub
Star
app/controllers/sessions_controller.rb

Summary

Maintainability
A
45 mins
Test Coverage
A
98%

Method create_from_secret has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def create_from_secret
    create_session do |params|
      permitted = secret_question_params
      @email = params[:email]
      u = Customer.authenticate_from_secret_question(@email, permitted, params[:answer])
Severity: Minor
Found in app/controllers/sessions_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

(...) interpreted as grouped expression.
Open

        redirect_to (u.errors.has_key?(:no_secret_question) ? login_path : new_from_secret_session_path)
Severity: Minor
Found in app/controllers/sessions_controller.rb by rubocop

Checks for space between the name of a called method and a left parenthesis.

Example:

# bad

puts (x + y)

Example:

# good

puts(x + y)

There are no issues that match your filters.

Category
Status