Sign upLogin

armandofox/audience1st

View on GitHub
Star
app/models/imported_order.rb

Summary

Maintainability
A
0 mins
Test Coverage
C
75%

Unused method argument - for_customer. If it's necessary, use _ or _for_customer as an argument name to indicate that it won't be used. You can also write as finalize(*) if you want the method to accept any arguments but don't care about them.
Open

  def finalize(for_customer, by_user)
Severity: Minor
Found in app/models/imported_order.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - by_user. If it's necessary, use _ or _by_user as an argument name to indicate that it won't be used. You can also write as finalize(*) if you want the method to accept any arguments but don't care about them.
Open

  def finalize(for_customer, by_user)
Severity: Minor
Found in app/models/imported_order.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

There are no issues that match your filters.

Category
Status