armandofox/audience1st

View on GitHub
app/models/items/retail_item.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
85%

Useless assignment to variable - item.
Open

    item = RetailItem.new(:amount => amount, :comments => description,
Severity: Minor
Found in app/models/items/retail_item.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Useless assignment to variable - item.
Open

    item = RetailItem.new(:vouchertype => vt, :amount => vt.price, :account_code => vt.account_code, :comments => vt.name)
Severity: Minor
Found in app/models/items/retail_item.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

There are no issues that match your filters.

Category
Status