armandofox/audience1st

Class Show has 22 methods (exceeds 20 allowed). Consider refactoring.

Open

class Show < ActiveRecord::Base

  REGULAR_SHOW = 'Regular Show'
  TYPES = [REGULAR_SHOW, 'Special Event', 'Class', 'Subscription']

Method Show#special? is defined at both app/models/show.rb:60 and app/models/show.rb:71.

Open

  def special? ; event_type != 'Regular Show' ; end

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad

def duplicated
  1
end

def duplicated
  2
end

# bad

def duplicated
  1
end

alias duplicated other_duplicated

# good

def duplicated
  1
end

def other_duplicated
  2
end

Method Show#special is defined at both app/models/show.rb:61 and app/models/show.rb:72.

Open

  def special ; special? ; end

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad

def duplicated
  1
end

def duplicated
  2
end

# bad

def duplicated
  1
end

alias duplicated other_duplicated

# good

def duplicated
  1
end

def other_duplicated
  2
end