Sign upLogin

armandofox/audience1st

View on GitHub
Star
app/models/showdate.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
97%

Class Showdate has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

class Showdate < ActiveRecord::Base

  include Comparable
  
  belongs_to :show
Severity: Minor
Found in app/models/showdate.rb - About 3 hrs to fix

    Cyclomatic complexity for from_date_list is too high. [7/6]
    Open

      def self.from_date_list(dates, sales_cutoff, params)
    # force boolean values to be false if fields are blank
    params[:stream_anytime] = false if params[:stream_anytime].blank?
    params[:live_stream] = false    if params[:live_stream].blank?
    if params[:live_stream] || params[:stream_anytime]
    Severity: Minor
    Found in app/models/showdate.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method from_date_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.from_date_list(dates, sales_cutoff, params)
    # force boolean values to be false if fields are blank
    params[:stream_anytime] = false if params[:stream_anytime].blank?
    params[:live_stream] = false    if params[:live_stream].blank?
    if params[:live_stream] || params[:stream_anytime]
    Severity: Minor
    Found in app/models/showdate.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Unused method argument - sales_cutoff. If it's necessary, use _ or _sales_cutoff as an argument name to indicate that it won't be used.
    Open

      def self.from_date_list(dates, sales_cutoff, params)
    Severity: Minor
    Found in app/models/showdate.rb by rubocop

    This cop checks for unused method arguments.

    Example:

    # bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

    Example:

    # good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

    Useless assignment to variable - new_showdates.
    Open

        new_showdates = dates.map do |date|
    Severity: Minor
    Found in app/models/showdate.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad

def some_method
  some_var = 1
  do_something
end

    Example:

    # good

def some_method
  some_var = 1
  do_something(some_var)
end

    There are no issues that match your filters.

    Category
    Status