Sign upLogin

armandofox/audience1st

View on GitHub
Star
app/models/ticket_offer.rb

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Cyclomatic complexity for initialize is too high. [7/6]
Open

  def initialize(showdate_as_date, _price, _noffered, _nsold,
                 name_str="%goldstar%")
    @price,@noffered,@nsold = _price,_noffered.to_i,_nsold.to_i
    raise(ArgumentError, "Number offered and sold must be >= 0") unless
      (@noffered >= 0 && @nsold >= 0)
Severity: Minor
Found in app/models/ticket_offer.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def initialize(showdate_as_date, _price, _noffered, _nsold,
                 name_str="%goldstar%")
    @price,@noffered,@nsold = _price,_noffered.to_i,_nsold.to_i
    raise(ArgumentError, "Number offered and sold must be >= 0") unless
      (@noffered >= 0 && @nsold >= 0)
Severity: Minor
Found in app/models/ticket_offer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def initialize(showdate_as_date, _price, _noffered, _nsold,
                 name_str="%goldstar%")
Severity: Minor
Found in app/models/ticket_offer.rb - About 35 mins to fix

    Do not use prefix _ for a variable that is used.
    Open

      def initialize(showdate_as_date, _price, _noffered, _nsold,
    Severity: Minor
    Found in app/models/ticket_offer.rb by rubocop

    This cop checks for underscore-prefixed variables that are actually used.

    Example:

    # bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

    Example:

    # good

[1, 2, 3].each do |num|
  do_something(num)
end

    Example:

    # good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

    Do not use prefix _ for a variable that is used.
    Open

      def initialize(showdate_as_date, _price, _noffered, _nsold,
    Severity: Minor
    Found in app/models/ticket_offer.rb by rubocop

    This cop checks for underscore-prefixed variables that are actually used.

    Example:

    # bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

    Example:

    # good

[1, 2, 3].each do |num|
  do_something(num)
end

    Example:

    # good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

    Do not use prefix _ for a variable that is used.
    Open

      def initialize(showdate_as_date, _price, _noffered, _nsold,
    Severity: Minor
    Found in app/models/ticket_offer.rb by rubocop

    This cop checks for underscore-prefixed variables that are actually used.

    Example:

    # bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

    Example:

    # good

[1, 2, 3].each do |num|
  do_something(num)
end

    Example:

    # good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

    There are no issues that match your filters.

    Category
    Status