Sign upLogin

armandofox/audience1st

View on GitHub
Star
app/services/ticket_sales_import_parser/goldstar.rb

Summary

Maintainability
B
4 hrs
Test Coverage
B
86%

Method has too many lines. [44/30]
Open

    def parse
      unless valid?
        return @import.errors.add(:base, 'Import is invalid')
      end
      # A Goldstar will-call is always for exactly 1 performance
Severity: Minor
Found in app/services/ticket_sales_import_parser/goldstar.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method parse has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def parse
      unless valid?
        return @import.errors.add(:base, 'Import is invalid')
      end
      # A Goldstar will-call is always for exactly 1 performance
Severity: Minor
Found in app/services/ticket_sales_import_parser/goldstar.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse
      unless valid?
        return @import.errors.add(:base, 'Import is invalid')
      end
      # A Goldstar will-call is always for exactly 1 performance
Severity: Minor
Found in app/services/ticket_sales_import_parser/goldstar.rb - About 1 hr to fix

    HACK found
    Open

                  # HACK. If this is a reserved seating performance, we have to provide "placeholder"
    Severity: Minor
    Found in app/services/ticket_sales_import_parser/goldstar.rb by fixme

    Useless assignment to variable - claims. Use _ or _claims as a variable name to indicate that it won't be used.
    Open

                purchase_id,first,last,date,claims = purchase.values_at('purchase_id','first_name','last_name','created_at','claims')
    Severity: Minor
    Found in app/services/ticket_sales_import_parser/goldstar.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad

def some_method
  some_var = 1
  do_something
end

    Example:

    # good

def some_method
  some_var = 1
  do_something(some_var)
end

    There are no issues that match your filters.

    Category
    Status