Sign upLogin

armandofox/audience1st

View on GitHub
Star
app/services/voucher_presenter.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
94%

Cyclomatic complexity for <=> is too high. [13/6]
Open

  def <=>(other)
    sd1,vt1 = self.showdate, self.vouchertype
    sd2,vt2 = other.showdate, other.vouchertype
    if vt1 == vt2
      # same vouchertype: order by OPENING DATE of the show for which reserved, or display order
Severity: Minor
Found in app/services/voucher_presenter.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method <=> has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def <=>(other)
    sd1,vt1 = self.showdate, self.vouchertype
    sd2,vt2 = other.showdate, other.vouchertype
    if vt1 == vt2
      # same vouchertype: order by OPENING DATE of the show for which reserved, or display order
Severity: Minor
Found in app/services/voucher_presenter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method menu_label_function has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def menu_label_function(admin_display = false)
    if admin_display
      single_production ? :date_with_explanation_for_admin : :name_with_explanation_for_admin
    else
      single_production ? :date_with_explanation : :name_with_explanation
Severity: Minor
Found in app/services/voucher_presenter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Odd else layout detected. Did you mean to use elsif?
Open

      return (if (sd1 && sd2) then (sd1 <=> sd2) else (vt1.display_order <=> vt2.display_order) end)
Severity: Minor
Found in app/services/voucher_presenter.rb by rubocop

This cop checks for odd else block layout - like having an expression on the same line as the else keyword, which is usually a mistake.

Example:

# bad

if something
  # ...
else do_this
  do_that
end

Example:

# good

if something
  # ...
else
  do_this
  do_that
end

There are no issues that match your filters.

Category
Status