armandofox/audience1st

View on GitHub
lib/core_extensions/time/season.rb

Summary

Maintainability
A
1 hr
Test Coverage
B
85%

Cyclomatic complexity for at_beginning_of_season is too high. [7/6]
Open

      def at_beginning_of_season(oldyear = nil)
        startmon = Option.season_start_month
        startday = Option.season_start_day
        if (oldyear)
          # year given: just return start of that season
Severity: Minor
Found in lib/core_extensions/time/season.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method at_beginning_of_season has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def at_beginning_of_season(oldyear = nil)
        startmon = Option.season_start_month
        startday = Option.season_start_day
        if (oldyear)
          # year given: just return start of that season
Severity: Minor
Found in lib/core_extensions/time/season.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Do not use prefix _ for a variable that is used.
Open

          _end = start.at_end_of_season
Severity: Minor
Found in lib/core_extensions/time/season.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

Do not use prefix _ for a variable that is used.
Open

        _end = start.at_end_of_season
Severity: Minor
Found in lib/core_extensions/time/season.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

There are no issues that match your filters.

Category
Status