arsduo/koala

View on GitHub
lib/koala/api.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
100%

Method graph_call has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

      def graph_call(path, args = {}, verb = "get", options = {}, &post_processing)
        # enable appsecret_proof by default
        options = {:appsecret_proof => true}.merge(options) if @app_secret
        response = api(path, args, verb, options)

Severity: Minor
Found in lib/koala/api.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method api has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def api(path, args = {}, verb = "get", options = {})
        # we make a copy of args so the modifications (added access_token & appsecret_proof)
        # do not affect the received argument
        args = args.dup

Severity: Minor
Found in lib/koala/api.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method graph_call has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def graph_call(path, args = {}, verb = "get", options = {}, &post_processing)
Severity: Minor
Found in lib/koala/api.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status