Sign upLogin

arsduo/koala

View on GitHub
Star
lib/koala/api/graph_api_methods.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
94%

Method parse_media_args has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def parse_media_args(media_args, method)
        # photo and video uploads can accept different types of arguments (see above)
        # so here, we parse the arguments into a form directly usable in put_connections
        raise KoalaError.new("Wrong number of arguments for put_#{method == "photos" ? "picture" : "video"}") unless media_args.size.between?(1, 5)
Severity: Minor
Found in lib/koala/api/graph_api_methods.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_connection has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def get_connection(id, connection_name, args = {}, options = {}, &block)
Severity: Minor
Found in lib/koala/api/graph_api_methods.rb - About 35 mins to fix

    Method put_connections has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def put_connections(id, connection_name, args = {}, options = {}, &block)
    Severity: Minor
    Found in lib/koala/api/graph_api_methods.rb - About 35 mins to fix

      Method put_object has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def put_object(parent_object, connection_name, args = {}, options = {}, &block)
      Severity: Minor
      Found in lib/koala/api/graph_api_methods.rb - About 35 mins to fix

        Method put_wall_post has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def put_wall_post(message, attachment = {}, target_id = "me", options = {}, &block)
        Severity: Minor
        Found in lib/koala/api/graph_api_methods.rb - About 35 mins to fix

          Method delete_connections has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def delete_connections(id, connection_name, args = {}, options = {}, &block)
          Severity: Minor
          Found in lib/koala/api/graph_api_methods.rb - About 35 mins to fix

            Method set_app_restrictions has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def set_app_restrictions(app_id, restrictions_hash, args = {}, options = {}, &block)
            Severity: Minor
            Found in lib/koala/api/graph_api_methods.rb - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    def delete_connections(id, connection_name, args = {}, options = {}, &block)
        # Deletes a given connection
        raise AuthenticationError.new(nil, nil, "Delete requires an access token") unless access_token
        graph_call("#{id}/#{connection_name}", args, "delete", options, &block)
              Severity: Minor
              Found in lib/koala/api/graph_api_methods.rb and 1 other location - About 15 mins to fix
              lib/koala/api/graph_api_methods.rb on lines 157..161

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    def put_connections(id, connection_name, args = {}, options = {}, &block)
        # Posts a certain connection
        raise AuthenticationError.new(nil, nil, "Write operations require an access token") unless access_token

        graph_call("#{id}/#{connection_name}", args, "post", options, &block)
              Severity: Minor
              Found in lib/koala/api/graph_api_methods.rb and 1 other location - About 15 mins to fix
              lib/koala/api/graph_api_methods.rb on lines 175..178

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status