Sign upLogin

artirix/browsercms

View on GitHub
Star
lib/cms/behaviors/attaching.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method validates_attachment_size has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def validates_attachment_size(name, options = {})

          min = options[:greater_than] || (options[:in] && options[:in].first) || 0
          max = options[:less_than] || (options[:in] && options[:in].last) || (1.0/0)
          range = (min..max)
Severity: Minor
Found in lib/cms/behaviors/attaching.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method associate_new_attachments has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def associate_new_attachments
          unless attachment_id_list.blank?
            ids = attachment_id_list.split(',').map(&:to_i)
            ids.each do |i|
              begin
Severity: Minor
Found in lib/cms/behaviors/attaching.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validates_attachment_presence has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def validates_attachment_presence(name, options = {})
          message = options.delete(:message) || "Must provide at least one #{name}"
          validate(options) do |record|
            return if record.deleted?
            unless record.attachments.any? { |a| a.attachment_name == name.to_s }
Severity: Minor
Found in lib/cms/behaviors/attaching.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status