artirix/browsercms

View on GitHub
lib/cms/behaviors/versioning.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method is_versioned has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def is_versioned(options={})
          @is_versioned = true

          @version_table_name = (options[:version_table_name] || "#{table_name.singularize}_versions").to_s

Severity: Minor
Found in lib/cms/behaviors/versioning.rb - About 1 hr to fix

    Method create_or_update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def create_or_update
              logger.debug { "#{self.class}#create_or_update called. Published = #{!!publish_on_save}" }
              self.skip_callbacks = false
              unless different_from_last_draft?
                logger.debug { "No difference between this version and last. Skipping save" }
    Severity: Minor
    Found in lib/cms/behaviors/versioning.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status