artur-graniszewski/ZEUS-for-PHP

View on GitHub
src/Zeus/ServerService/Async/AsyncPlugin.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function join has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function join($callId)
    {
        $callIds = is_array($callId) ? $callId : [$callId];

        $results = [];
Severity: Minor
Found in src/Zeus/ServerService/Async/AsyncPlugin.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method join has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function join($callId)
    {
        $callIds = is_array($callId) ? $callId : [$callId];

        $results = [];
Severity: Minor
Found in src/Zeus/ServerService/Async/AsyncPlugin.php - About 1 hr to fix

    Method doJoin has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function doJoin(ConnectionInterface $socket)
        {
            $result = $socket->read();
            if ($result === false) {
                throw new \RuntimeException("Async call failed: server connection lost", 1);
    Severity: Minor
    Found in src/Zeus/ServerService/Async/AsyncPlugin.php - About 1 hr to fix

      Function doJoin has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function doJoin(ConnectionInterface $socket)
          {
              $result = $socket->read();
              if ($result === false) {
                  throw new \RuntimeException("Async call failed: server connection lost", 1);
      Severity: Minor
      Found in src/Zeus/ServerService/Async/AsyncPlugin.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run(\Closure $callable)
          {
              if (!class_exists('Opis\Closure\SerializableClosure')) {
                  throw new \LogicException("Async call failed: serialization module is missing");
              }
      Severity: Minor
      Found in src/Zeus/ServerService/Async/AsyncPlugin.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status