Sign upLogin

asfoury/projmag

View on GitHub
Star

Showing 24 of 26 total issues

Method loadUsersData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private fun loadUsersData() {
        try {
            usersRootDir.listFiles()?.forEach { userDir ->
                userDir.listFiles()?.forEach { file ->
                    file.parentFile?.name?.let { userID ->
Severity: Minor
Found in app/src/main/java/com/sdp13epfl2021/projmag/database/impl/cache/OfflineCachedUserdataDatabase.kt - About 1 hr to fix

    Method onCreate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_user_type_choice)
        val settings = getSharedPreferences(savedTypeChoice, Context.MODE_PRIVATE)
        val editor = settings.edit()
    Severity: Minor
    Found in app/src/main/java/com/sdp13epfl2021/projmag/activities/UserTypeChoice.kt - About 1 hr to fix

      Method getProjectsFromTags has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

          override fun getProjectsFromTags(
        tags: List<String>,
        onSuccess: (List<ImmutableProject>) -> Unit,
        onFailure: (Exception) -> Unit
    ) {
      Severity: Minor
      Found in app/src/main/java/com/sdp13epfl2021/projmag/database/impl/cache/OfflineProjectDatabase.kt - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method loadUsersData has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
      Open

          private fun loadUsersData() {
        try {
            usersRootDir.listFiles()?.forEach { userDir ->
                userDir.listFiles()?.forEach { file ->
                    file.parentFile?.name?.let { userID ->
      Severity: Minor
      Found in app/src/main/java/com/sdp13epfl2021/projmag/database/impl/cache/OfflineCachedUserdataDatabase.kt - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language