Sign upLogin

aspiers/git-deps

View on GitHub
Star
git_deps/detector.py

Summary

Maintainability
C
1 day
Test Coverage

File detector.py has 290 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import re
import subprocess

import pygit2
Severity: Minor
Found in git_deps/detector.py - About 2 hrs to fix

    Function tree_lookup has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def tree_lookup(self, target_path, commit):
        """Navigate to the tree or blob object pointed to by the given target
        path for the given commit.  This is necessary because each git
        tree only contains entries for the directory it refers to, not
        recursively for all subdirectories.
    Severity: Minor
    Found in git_deps/detector.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function find_dependencies has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def find_dependencies(self, dependent_rev, recurse=None):
        """Find all dependencies of the given revision, recursively traversing
        the dependency tree if requested.
        """
        if recurse is None:
    Severity: Minor
    Found in git_deps/detector.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function record_dependency_source has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def record_dependency_source(self, parent,
    Severity: Major
    Found in git_deps/detector.py - About 1 hr to fix

      Function process_new_dependency has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def process_new_dependency(self, dependent, dependent_sha1,
      Severity: Minor
      Found in git_deps/detector.py - About 45 mins to fix

        Function process_blame_hunk has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def process_blame_hunk(self, dependent, dependent_sha1, parent,
        Severity: Minor
        Found in git_deps/detector.py - About 45 mins to fix

          Function is_excluded has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Invalid

              def is_excluded(self, commit):
        if self.options.exclude_commits is not None:
            for exclude in self.options.exclude_commits:
                if self.branch_contains(commit, exclude):
                    return True
          Severity: Minor
          Found in git_deps/detector.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function process_new_dependency has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def process_new_dependency(self, dependent, dependent_sha1,
                               dependency, dependency_sha1,
                               path, line_num):
        if not self.seen_commit(dependency):
            self.notify_listeners("new_commit", dependency)
          Severity: Minor
          Found in git_deps/detector.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function debug_hunk has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def debug_hunk(self, line_range_before, line_range_after, hunk,
                   line_to_culprit):
        diff_format = '          | %8.8s %5s %s%s'
        hunk_header = '@@ %s %s @@' % (line_range_before, line_range_after)
        self.logger.debug(diff_format % ('--------', '-----', '', hunk_header))
          Severity: Minor
          Found in git_deps/detector.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status