Sign upLogin

assemblymade/coderwall

View on GitHub
Star
app/models/team.rb

Summary

Maintainability
F
4 days
Test Coverage

Class Team has 128 methods (exceeds 20 allowed). Consider refactoring.
Open

class Team < ActiveRecord::Base
  DEFAULT_HEX_BRAND        = '#343131'
  FEATURED_TEAMS_CACHE_KEY = 'featured_teams_results'
  MAX_TEAM_SCORE           = 400
Severity: Major
Found in app/models/team.rb - About 2 days to fix

    File team.rb has 600 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'search'

class Team < ActiveRecord::Base
  DEFAULT_HEX_BRAND        = '#343131'
  FEATURED_TEAMS_CACHE_KEY = 'featured_teams_results'
    Severity: Major
    Found in app/models/team.rb - About 1 day to fix

      Method search has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.search(query_string, country, page, per_page, search_type = :query_and_fetch)
    country = query_string.gsub!(/country:(.+)/, '') && $1 if country.nil?
    query = ''

    if query_string.blank? or query_string =~ /:/
      Severity: Minor
      Found in app/models/team.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method visitor_data has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def visitor_data(exit_url, exit_target_type, furthest_scrolled, time_spent, user_id, visited_at, user)
      Severity: Major
      Found in app/models/team.rb - About 50 mins to fix

        Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def self.search(query_string, country, page, per_page, search_type = :query_and_fetch)
        Severity: Minor
        Found in app/models/team.rb - About 35 mins to fix

          Method <=> has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def <=> y
    val = team_size_threshold <=> y.team_size_threshold
    return val unless val == 0

    val = score <=> y.score
          Severity: Minor
          Found in app/models/team.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def viewed_by(viewer)
    epoch_now = Time.now.to_i
    Redis.current.incr(impressions_key)
    if viewer.is_a?(User)
      Redis.current.zadd(user_views_key, epoch_now, viewer.id)
          Severity: Minor
          Found in app/models/team.rb and 1 other location - About 20 mins to fix
          app/models/opportunity.rb on lines 154..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status