Avoid excessively long class names like RequestHandlerClassDoesNotExistsException. Keep class name length under 40.

Open

final class RequestHandlerClassDoesNotExistsException extends OEmbedException
{
    public function __construct(Provider $provider)
    {
        $message = 'The configured renderer class %s of provider: %s does not exists.';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Avoid excessively long variable names like $afterFormEnginePageInitializedEvent. Keep variable name length under 30.

Open

    public function __invoke(AfterFormEnginePageInitializedEvent $afterFormEnginePageInitializedEvent): void

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Function handleUrlInputBlur has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  handleUrlInputBlur(urlInput) {
    if (!urlInput.value.includes('<iframe')) {
      return;
    }

Avoid using undefined variables such as '$queryParams' which will lead to PHP notices.

Open

            return $this->urlService->mergeQueryParameters($url, $queryParams);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$queryParams' which will lead to PHP notices.

Open

            $queryParams['rel'] = $response->getConfiguration()->shouldPlayRelated() ? '1' : '0';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Method startRequestLoop has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function startRequestLoop(Configuration $configuration): void
    {
        $response = null;
        $request = null;

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 14 and the first side effect is on line 14.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

        int $uid,
        string $url,
        int $maxHeight = 0,
        int $maxWidth = 0,
        bool $playRelated = true,

The class OembedController has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13.

Open

class OembedController extends ActionController
{
    private ConfigurationFactory $configurationFactory;

    private ContainerInterface $container;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Opening brace of a class must be on the line after the definition

Open

class LinkResponse extends GenericResponse {}

• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

class ProcessorException extends OEmbedException {}

• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

class InvalidConfigurationException extends OEmbedException {}

• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

abstract class OEmbedException extends Exception {}

• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

class RequestException extends OEmbedException {}

• Exclude checks
  • Disable engine
  • Disable check

The method __construct has a boolean flag argument $playRelated, which is a certain sign of a Single Responsibility Principle violation.

Open

        bool $playRelated = true,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid too many return statements within this function.

Open

      return;

Function handleUrlInputBlur has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

  handleUrlInputBlur(urlInput) {
    if (!urlInput.value.includes('<iframe')) {
      return;
    }

• Read up
  Read up

Avoid unused parameters such as '$afterFormEnginePageInitializedEvent'.

Open

    public function __invoke(AfterFormEnginePageInitializedEvent $afterFormEnginePageInitializedEvent): void

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Arguments with default values must be at the end of the argument list

Open

        string $aspectRatio = '',

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected 8 spaces, found 12

Open

            },

• Exclude checks
  • Disable engine
  • Disable check