Sign upLogin

astehlik/typo3-extension-mediaoembed

View on GitHub
Star

Showing 6 of 17 total issues

Function handleUrlInputBlur has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  handleUrlInputBlur(urlInput) {
    if (!urlInput.value.includes('<iframe')) {
      return;
    }
Severity: Minor
Found in Resources/Public/JavaScript/backend/url-parser.js - About 1 hr to fix

    Method startRequestLoop has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function startRequestLoop(Configuration $configuration): void
    {
        $response = null;
        $request = null;
    Severity: Minor
    Found in Classes/Controller/OembedController.php - About 1 hr to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              int $uid,
        string $url,
        int $maxHeight = 0,
        int $maxWidth = 0,
        bool $playRelated = true,
      Severity: Minor
      Found in Classes/Domain/Model/Content.php - About 45 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->createResponseGeneric($finalResponseData, $configuration);
        Severity: Major
        Found in Classes/Response/ResponseBuilder.php - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return;
          Severity: Major
          Found in Resources/Public/JavaScript/backend/url-parser.js - About 30 mins to fix

            Function handleUrlInputBlur has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              handleUrlInputBlur(urlInput) {
    if (!urlInput.value.includes('<iframe')) {
      return;
    }
            Severity: Minor
            Found in Resources/Public/JavaScript/backend/url-parser.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language