asteris-llc/converge

View on GitHub

Showing 247 of 615 total issues

Method Volume.Apply has 6 return statements (exceeds 4 allowed).
Open

func (v *Volume) Apply(context.Context) (resource.TaskStatus, error) {
    status := resource.NewStatus()

    var (
        vol *dc.Volume
Severity: Major
Found in resource/docker/volume/volume.go - About 40 mins to fix

    Method grapher.Graph has 6 return statements (exceeds 4 allowed).
    Open

    func (g *grapher) Graph(in *pb.LoadRequest, stream pb.Grapher_GraphServer) error {
        logger, ctx := setIDLogger(stream.Context())
        logger = logger.WithField("function", "grapher.Graph")
    
        loaded, err := in.Load(ctx)
    Severity: Major
    Found in rpc/grapher.go - About 40 mins to fix

      Method Printer.Show has 6 return statements (exceeds 4 allowed).
      Open

      func (p Printer) Show(ctx context.Context, g *graph.Graph) (string, error) {
          outputBuffer := new(bytes.Buffer)
          write := func(s Renderable) { outputBuffer.WriteString(s.String()) }
      
          subgraphs := makeSubgraphMap()
      Severity: Major
      Found in prettyprinters/prettyprinter.go - About 40 mins to fix

        Function expandSwitchMacro has 6 return statements (exceeds 4 allowed).
        Open

        func expandSwitchMacro(data []byte, current *source, n *parse.Node, g *graph.Graph) (*graph.Graph, error) {
            if !control.IsSwitchNode(n) {
                return g, nil
            }
            switchObj, err := control.NewSwitch(n, data)
        Severity: Major
        Found in load/nodes.go - About 40 mins to fix

          Method Printer.DrawNode has 6 return statements (exceeds 4 allowed).
          Open

          func (p *Printer) DrawNode(g *graph.Graph, id string) (pp.Renderable, error) {
              meta, ok := g.Get(id)
              if !ok {
                  return pp.HiddenString(), nil
              }
          Severity: Major
          Found in prettyprinters/human/human.go - About 40 mins to fix

            Function TestNotifyTransform has 6 return statements (exceeds 4 allowed).
            Open

            func TestNotifyTransform(t *testing.T) {
                g := graph.New()
                g.Add(node.New("root", 1))
            
                doNothing := func(*node.Node, *graph.Graph) error { return nil }
            Severity: Major
            Found in graph/notifier_test.go - About 40 mins to fix

              Function loadKeyring has 6 return statements (exceeds 4 allowed).
              Open

              func loadKeyring(ks *Keystore) (openpgp.KeyRing, error) {
                  var keyring openpgp.EntityList
                  trustedKeys := make(map[string]*openpgp.Entity)
              
                  for _, p := range []string{ks.SystemPath, ks.UserPath, ks.LocalPath} {
              Severity: Major
              Found in keystore/keystore.go - About 40 mins to fix

                Function VertexSplitTraverse has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func VertexSplitTraverse(g *graph.Graph, toFind string, startingNode string, stop func(*graph.Graph, string) bool, history map[string]struct{}) (string, string, bool) {
                Severity: Minor
                Found in render/preprocessor/preprocessor.go - About 35 mins to fix

                  Method Preparer.convertInterface has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func (p *Preparer) convertInterface(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                  Severity: Minor
                  Found in resource/preparer.go - About 35 mins to fix

                    Method Preparer.convertValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func (p *Preparer) convertValue(typ reflect.Type, r Renderer, name string, val interface{}, base int) (out reflect.Value, err error) {
                    Severity: Minor
                    Found in resource/preparer.go - About 35 mins to fix

                      Method Preparer.convertMap has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      func (p *Preparer) convertMap(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                      Severity: Minor
                      Found in resource/preparer.go - About 35 mins to fix

                        Method Preparer.convertPointer has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        func (p *Preparer) convertPointer(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                        Severity: Minor
                        Found in resource/preparer.go - About 35 mins to fix

                          Method Preparer.convertTime has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          func (p *Preparer) convertTime(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                          Severity: Minor
                          Found in resource/preparer.go - About 35 mins to fix

                            Method Preparer.convertDuration has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            func (p *Preparer) convertDuration(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                            Severity: Minor
                            Found in resource/preparer.go - About 35 mins to fix

                              Method Preparer.convertNumber has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              func (p *Preparer) convertNumber(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                              Severity: Minor
                              Found in resource/preparer.go - About 35 mins to fix

                                Method Preparer.convertSlice has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                func (p *Preparer) convertSlice(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                                Severity: Minor
                                Found in resource/preparer.go - About 35 mins to fix

                                  Function simpleApplySuccess has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  func simpleApplySuccess(t *testing.T, lvm lowlevel.LVM, group string, name string, size *lowlevel.LvmSize) resource.TaskStatus {
                                  Severity: Minor
                                  Found in resource/lvm/lv/lv_test.go - About 35 mins to fix

                                    Function simpleApplyFailure has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                    func simpleApplyFailure(t *testing.T, lvm lowlevel.LVM, group string, name string, size *lowlevel.LvmSize) resource.TaskStatus {
                                    Severity: Minor
                                    Found in resource/lvm/lv/lv_test.go - About 35 mins to fix

                                      Function simpleCheckFailure has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                      func simpleCheckFailure(t *testing.T, lvm lowlevel.LVM, group string, name string, size *lowlevel.LvmSize) resource.TaskStatus {
                                      Severity: Minor
                                      Found in resource/lvm/lv/lv_test.go - About 35 mins to fix

                                        Function newMockOS has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                        func newMockOS(ownedFiles []ownershipRecord,
                                            users []*user.User,
                                            groups []*user.Group,
                                            defaultUser *user.User,
                                            defaultGroup *user.Group,
                                        Severity: Minor
                                        Found in resource/file/owner/helper_test.go - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language