Sign upLogin

asteris-llc/converge

View on GitHub
Star

Showing 615 of 615 total issues

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/docker/network/network.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/systemd/unit/executor_linux_test.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/systemd/unit/linux_mocks_test.go by gofmt

Double quote to prevent globbing and word splitting.
Open

        echo $i
Severity: Minor
Found in check_license.sh by shellcheck

Double quote to prevent globbing and word splitting.

Problematic code:

echo $1
for i in $*; do :; done # this done and the next one also applies to expanding arrays.
for i in $@; do :; done

Correct code:

echo "$1"
for i in "$@"; do :; done # or, 'for i; do'

Rationale

The first code looks like "print the first argument". It's actually "Split the first argument by IFS (spaces, tabs and line feeds). Expand each of them as if it was a glob. Join all the resulting strings and filenames with spaces. Print the result."

The second one looks like "iterate through all arguments". It's actually "join all the arguments by the first character of IFS (space), split them by IFS and expand each of them as globs, and iterate on the resulting list". The third one skips the joining part.

Quoting variables prevents word splitting and glob expansion, and prevents the script from breaking when input contains spaces, line feeds, glob characters and such.

Strictly speaking, only expansions themselves need to be quoted, but for stylistic reasons, entire arguments with multiple variable and literal parts are often quoted as one:

$HOME/$dir/dist/bin/$file        # Unquoted (bad)
"$HOME"/"$dir"/dist/bin/"$file"  # Minimal quoting (good)
"$HOME/$dir/dist/bin/$file"      # Canonical quoting (good)

When quoting composite arguments, make sure to exclude globs and brace expansions, which lose their special meaning in double quotes: "$HOME/$dir/src/*.c" will not expand, but "$HOME/$dir/src"/*.c will.

Note that $( ) starts a new context, and variables in it have to be quoted independently:

echo "This $variable is quoted $(but this $variable is not)"
echo "This $variable is quoted $(and now this "$variable" is too)"

Exceptions

Sometimes you want to split on spaces, like when building a command line:

options="-j 5 -B"
make $options file

Just quoting this doesn't work. Instead, you should have used an array (bash, ksh, zsh):

options=(-j 5 -B) # ksh: set -A options -- -j 5 -B
make "${options[@]}" file

or a function (POSIX):

make_with_flags() { make -j 5 -B "$@"; }
make_with_flags file

To split on spaces but not perform glob expansion, Posix has a set -f to disable globbing. You can disable word splitting by setting IFS=''.

Similarly, you might want an optional argument:

debug=""
[[ $1 == "--trace-commands" ]] && debug="-x"
bash $debug script

Quoting this doesn't work, since in the default case, "$debug" would expand to one empty argument while $debug would expand into zero arguments. In this case, you can use an array with zero or one elements as outlined above, or you can use an unquoted expansion with an alternate value:

debug=""
[[ $1 == "--trace-commands" ]] && debug="yes"
bash ${debug:+"-x"} script

This is better than an unquoted value because the alternative value can be properly quoted, e.g. wget ${output:+ -o "$output"}.

As always, this warning can be [[ignore]]d on a case-by-case basis.

this is especially relevant when BASH many not be available for the array work around. For example, use in eval or in command options where script has total control of the variables...

FLAGS="-av -e 'ssh -x' --delete --delete-excluded"
...
# shellcheck disable=SC2086
eval rsync $FLAGS ~/dir remote_host:dir

Notice

Original content from the ShellCheck https://github.com/koalaman/shellcheck/wiki.

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build gofuzz
Severity: Minor
Found in cmd/params_fuzz.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in prettyprinters/subgraph_printer.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/docker/volume/volume_test.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/group/group_default.go by gofmt

Double quote to prevent globbing and word splitting.
Open

FILES=$(find ${SRC_DIRS} -type f -name '*.go')
Severity: Minor
Found in check_license.sh by shellcheck

Double quote to prevent globbing and word splitting.

Problematic code:

echo $1
for i in $*; do :; done # this done and the next one also applies to expanding arrays.
for i in $@; do :; done

Correct code:

echo "$1"
for i in "$@"; do :; done # or, 'for i; do'

Rationale

The first code looks like "print the first argument". It's actually "Split the first argument by IFS (spaces, tabs and line feeds). Expand each of them as if it was a glob. Join all the resulting strings and filenames with spaces. Print the result."

The second one looks like "iterate through all arguments". It's actually "join all the arguments by the first character of IFS (space), split them by IFS and expand each of them as globs, and iterate on the resulting list". The third one skips the joining part.

Quoting variables prevents word splitting and glob expansion, and prevents the script from breaking when input contains spaces, line feeds, glob characters and such.

Strictly speaking, only expansions themselves need to be quoted, but for stylistic reasons, entire arguments with multiple variable and literal parts are often quoted as one:

$HOME/$dir/dist/bin/$file        # Unquoted (bad)
"$HOME"/"$dir"/dist/bin/"$file"  # Minimal quoting (good)
"$HOME/$dir/dist/bin/$file"      # Canonical quoting (good)

When quoting composite arguments, make sure to exclude globs and brace expansions, which lose their special meaning in double quotes: "$HOME/$dir/src/*.c" will not expand, but "$HOME/$dir/src"/*.c will.

Note that $( ) starts a new context, and variables in it have to be quoted independently:

echo "This $variable is quoted $(but this $variable is not)"
echo "This $variable is quoted $(and now this "$variable" is too)"

Exceptions

Sometimes you want to split on spaces, like when building a command line:

options="-j 5 -B"
make $options file

Just quoting this doesn't work. Instead, you should have used an array (bash, ksh, zsh):

options=(-j 5 -B) # ksh: set -A options -- -j 5 -B
make "${options[@]}" file

or a function (POSIX):

make_with_flags() { make -j 5 -B "$@"; }
make_with_flags file

To split on spaces but not perform glob expansion, Posix has a set -f to disable globbing. You can disable word splitting by setting IFS=''.

Similarly, you might want an optional argument:

debug=""
[[ $1 == "--trace-commands" ]] && debug="-x"
bash $debug script

Quoting this doesn't work, since in the default case, "$debug" would expand to one empty argument while $debug would expand into zero arguments. In this case, you can use an array with zero or one elements as outlined above, or you can use an unquoted expansion with an alternate value:

debug=""
[[ $1 == "--trace-commands" ]] && debug="yes"
bash ${debug:+"-x"} script

This is better than an unquoted value because the alternative value can be properly quoted, e.g. wget ${output:+ -o "$output"}.

As always, this warning can be [[ignore]]d on a case-by-case basis.

this is especially relevant when BASH many not be available for the array work around. For example, use in eval or in command options where script has total control of the variables...

FLAGS="-av -e 'ssh -x' --delete --delete-excluded"
...
# shellcheck disable=SC2086
eval rsync $FLAGS ~/dir remote_host:dir

Notice

Original content from the ShellCheck https://github.com/koalaman/shellcheck/wiki.

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/docker/container/preparer.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/docker/port_test.go by gofmt

func setUid should be setUID
Open

func setUid() (string, error) {
Severity: Minor
Found in resource/user/user_test.go by golint

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/systemd/unit/systemd_connection_mock_test.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/systemd/unit/systemd_linux_test.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in render/extensions/platform/osx_test.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/docker/docker.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// Copyright © 2016 Asteris, LLC
Severity: Minor
Found in resource/docker/volume/preparer_test.go by gofmt

TODO found
Open

    <!-- TODO: disabled until Hugo supports the generation of a content index natively
Severity: Minor
Found in docs/themes/hugo-material-docs/layouts/partials/header.html by fixme

TODO found
Open

    ID    string      `json:"id"` // TODO: preserved for compat, remove in 0.4.0
Severity: Minor
Found in prettyprinters/jsonl/jsonl.go by fixme

TODO found
Open

        // TODO: when this grows any pointers, they should be tested here too
Severity: Minor
Found in graph/node/node_test.go by fixme
Severity
Category
Status
Source
Language