Sign upLogin

asteris-llc/converge

View on GitHub
Star
resource/lvm/fs/fs_test.go

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func simpleApplyFailure(t *testing.T, lvm lowlevel.LVM) resource.TaskStatus {
    checkStatus, res := simpleCheckSuccess(t, lvm)
    require.True(t, checkStatus.HasChanges())
    status, err := res.Apply(context.Background())
    assert.Error(t, err)
Severity: Minor
Found in resource/lvm/fs/fs_test.go and 1 other location - About 45 mins to fix
resource/lvm/fs/fs_test.go on lines 218..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func simpleApplySuccess(t *testing.T, lvm lowlevel.LVM) resource.TaskStatus {
    checkStatus, res := simpleCheckSuccess(t, lvm)
    require.True(t, checkStatus.HasChanges())
    status, err := res.Apply(context.Background())
    assert.NoError(t, err)
Severity: Minor
Found in resource/lvm/fs/fs_test.go and 1 other location - About 45 mins to fix
resource/lvm/fs/fs_test.go on lines 227..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    t.Run("no mkfs, only unit update and mount", func(t *testing.T) {
        lvm, m := testhelpers.MakeFakeLvm()
        setupNormalFlowApply(m, "xfs", true, false) // "xfs", no unit diffs, mount is NOT mounted
        _ = simpleApplySuccess(t, lvm)
        m.AssertNotCalled(t, "Mkfs", "/dev/mapper/vg0-data", "xfs")
Severity: Minor
Found in resource/lvm/fs/fs_test.go and 2 other locations - About 40 mins to fix
resource/lvm/fs/fs_test.go on lines 95..102
resource/lvm/fs/fs_test.go on lines 114..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    t.Run("no mkfs, no unit, only mount", func(t *testing.T) {
        lvm, m := testhelpers.MakeFakeLvm()
        setupNormalFlowApply(m, "xfs", false, false)
        _ = simpleApplySuccess(t, lvm)
        m.AssertNotCalled(t, "Mkfs", "/dev/mapper/vg0-data", "xfs")
Severity: Minor
Found in resource/lvm/fs/fs_test.go and 2 other locations - About 40 mins to fix
resource/lvm/fs/fs_test.go on lines 95..102
resource/lvm/fs/fs_test.go on lines 104..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    t.Run("normal flow", func(t *testing.T) {
        lvm, m := testhelpers.MakeFakeLvm()
        setupNormalFlowApply(m, "", true, true)
        _ = simpleApplySuccess(t, lvm)
        m.AssertCalled(t, "Mkfs", "/dev/mapper/vg0-data", "xfs")
Severity: Minor
Found in resource/lvm/fs/fs_test.go and 2 other locations - About 40 mins to fix
resource/lvm/fs/fs_test.go on lines 104..112
resource/lvm/fs/fs_test.go on lines 114..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status