Showing 12 of 12 total issues
Method update_dependency
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update_dependency(dependency, chef_info, repo_info)
dependency.status = :up_to_date
if !chef_info[:version_used]
dependency.status = :err_req
Method compare_repo_chef
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def compare_repo_chef(chef_info, repo_info)
comparison = {:chef => :up_to_date, :repo => :up_to_date,
:remarks => []}
if chef_info[:latest_version] && repo_info[:latest_metadata]
Method update_dependency
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def update_dependency(dependency, chef_info, repo_info)
dependency.status = :up_to_date
if !chef_info[:version_used]
dependency.status = :err_req
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method investigate
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def investigate(dependency, version_used, recursive)
repo_dependencies = []
projects = @manager.projects_by_name(dependency.name)
if projects.empty?
Method compare_repo_chef
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def compare_repo_chef(chef_info, repo_info)
comparison = {:chef => :up_to_date, :repo => :up_to_date,
:remarks => []}
if chef_info[:latest_version] && repo_info[:latest_metadata]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method single_status
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def single_status(dep)
return mark_structure(:err_req) if dep.status == :err_req
return mark_structure(:err_repo) if dep.repomanager[:status] == :err_repo
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method investigate
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def investigate(dependency, version_used, recursive)
repo_dependencies = []
projects = @manager.projects_by_name(dependency.name)
if projects.empty?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return mark_structure(:warn_mismatch_repo) if dep.repomanager[:status] == :warn_mismatch_repo
Avoid too many return
statements within this method. Open
return mark_structure(:warn_chef) if dep.chef[:status] == :warn_chef
Avoid too many return
statements within this method. Open
return mark_structure(:warn_notunique_repo) if dep.repomanager[:status] == :warn_notunique_repo
Method to_hash
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def to_hash
{}.tap do |hash|
hash[:name] = name
hash[:requirement] = requirement
hash[:status] = status
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def initialize(config)
@chef_server_url = config[:url]
@chef_username = config[:username]
@chef_client_pem = config[:client_pem]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"