Sign upLogin

astratto/kitchen-inspector

View on GitHub
Star

Showing 12 of 12 total issues

Method update_dependency has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def update_dependency(dependency, chef_info, repo_info)
        dependency.status = :up_to_date

        if !chef_info[:version_used]
          dependency.status = :err_req
Severity: Minor
Found in lib/kitchen-inspector/inspector/health_bureau.rb - About 1 hr to fix

    Method compare_repo_chef has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def compare_repo_chef(chef_info, repo_info)
        comparison = {:chef => :up_to_date, :repo => :up_to_date,
                  :remarks => []}

        if chef_info[:latest_version] && repo_info[:latest_metadata]
    Severity: Minor
    Found in lib/kitchen-inspector/inspector/health_bureau.rb - About 1 hr to fix

      Method update_dependency has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def update_dependency(dependency, chef_info, repo_info)
        dependency.status = :up_to_date

        if !chef_info[:version_used]
          dependency.status = :err_req
      Severity: Minor
      Found in lib/kitchen-inspector/inspector/health_bureau.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method investigate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def investigate(dependency, version_used, recursive)
        repo_dependencies = []
        projects = @manager.projects_by_name(dependency.name)

        if projects.empty?
      Severity: Minor
      Found in lib/kitchen-inspector/inspector/repository_inspector.rb - About 1 hr to fix

        Method compare_repo_chef has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def compare_repo_chef(chef_info, repo_info)
        comparison = {:chef => :up_to_date, :repo => :up_to_date,
                  :remarks => []}

        if chef_info[:latest_version] && repo_info[:latest_metadata]
        Severity: Minor
        Found in lib/kitchen-inspector/inspector/health_bureau.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method single_status has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def single_status(dep)
          return mark_structure(:err_req) if dep.status == :err_req

          return mark_structure(:err_repo) if dep.repomanager[:status] == :err_repo
        Severity: Minor
        Found in lib/kitchen-inspector/inspector/report/status_reporter.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method investigate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def investigate(dependency, version_used, recursive)
        repo_dependencies = []
        projects = @manager.projects_by_name(dependency.name)

        if projects.empty?
        Severity: Minor
        Found in lib/kitchen-inspector/inspector/repository_inspector.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                  return mark_structure(:warn_mismatch_repo) if dep.repomanager[:status] == :warn_mismatch_repo
        Severity: Major
        Found in lib/kitchen-inspector/inspector/report/status_reporter.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return mark_structure(:warn_chef) if dep.chef[:status] == :warn_chef
          Severity: Major
          Found in lib/kitchen-inspector/inspector/report/status_reporter.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return mark_structure(:warn_notunique_repo) if dep.repomanager[:status] == :warn_notunique_repo
            Severity: Major
            Found in lib/kitchen-inspector/inspector/report/status_reporter.rb - About 30 mins to fix

              Method to_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def to_hash
          {}.tap do |hash|
            hash[:name] = name
            hash[:requirement] = requirement
            hash[:status] = status
              Severity: Minor
              Found in lib/kitchen-inspector/inspector/models/dependency.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def initialize(config)
        @chef_server_url = config[:url]
        @chef_username = config[:username]
        @chef_client_pem = config[:client_pem]
              Severity: Minor
              Found in lib/kitchen-inspector/inspector/chef_inspector.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language