astroband/ruby-stellar-sdk

View on GitHub
base/lib/stellar/claim_predicate.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
93%

Method describe has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def describe
      case switch
      when ClaimPredicateType::UNCONDITIONAL
        "always"
      when ClaimPredicateType::BEFORE_RELATIVE_TIME
Severity: Minor
Found in base/lib/stellar/claim_predicate.rb - About 1 hr to fix

    Method evaluate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def evaluate(created_at, claiming_at)
          created_at = created_at.to_time if created_at.respond_to?(:to_time)
          claiming_at = created_at + claiming_at if claiming_at.is_a?(ActiveSupport::Duration)
          claiming_at = claiming_at.to_time if claiming_at.respond_to?(:to_time)
    
    
    Severity: Minor
    Found in base/lib/stellar/claim_predicate.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category