atelierspierrot/library

View on GitHub
src/Library/CommandLine/Helper.php

Summary

Maintainability
F
5 days
Test Coverage

Function formatHelpString has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

    public static function formatHelpString($title = null, $contents = null, Formater $formater)
    {
        if (empty($contents)) return '';
        if (empty($title)) $title = 'Help';
        if (!is_array($contents)) $contents = array( $contents );
Severity: Minor
Found in src/Library/CommandLine/Helper.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getHelpInfo has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getHelpInfo(array $options = array(), Formater $formater, $caller)
    {
        if (!is_object($caller) || !($caller instanceof CommandLineControllerInterface)) {
            throw new InvalidArgumentException(
                sprintf('Argument 3 for method "%s::getHelpInfo" must be an object and implement the "CommandLineControllerInterface" interface!', __CLASS__)
Severity: Minor
Found in src/Library/CommandLine/Helper.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getHelpInfo has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getHelpInfo(array $options = array(), Formater $formater, $caller)
    {
        if (!is_object($caller) || !($caller instanceof CommandLineControllerInterface)) {
            throw new InvalidArgumentException(
                sprintf('Argument 3 for method "%s::getHelpInfo" must be an object and implement the "CommandLineControllerInterface" interface!', __CLASS__)
Severity: Major
Found in src/Library/CommandLine/Helper.php - About 3 hrs to fix

    Method formatHelpString has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function formatHelpString($title = null, $contents = null, Formater $formater)
        {
            if (empty($contents)) return '';
            if (empty($title)) $title = 'Help';
            if (!is_array($contents)) $contents = array( $contents );
    Severity: Minor
    Found in src/Library/CommandLine/Helper.php - About 1 hr to fix

      Function treatOptions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function treatOptions(array $options, $caller)
          {
              if (!is_object($caller) || !($caller instanceof CommandLineControllerInterface)) {
                  throw new InvalidArgumentException(
                      sprintf('Argument 2 for method "%s::treatOptions" must be an object and implement the "CommandLineControllerInterface" interface!', __CLASS__)
      Severity: Minor
      Found in src/Library/CommandLine/Helper.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getopt has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getopt(array $options)
          {
              $short_options = implode('', array_keys($options['argv_options']));
              $long_options = array_keys($options['argv_long_options']);
              if (!empty($options['commands'])) {
      Severity: Minor
      Found in src/Library/CommandLine/Helper.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getOptionDescription has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getOptionDescription($arg, $caller)
          {
              if (!is_object($caller) || !($caller instanceof CommandLineControllerInterface)) {
                  throw new InvalidArgumentException(
                      sprintf('Argument 2 for method "%s::getOptionDescription" must be an object and implement the "CommandLineControllerInterface" interface!', __CLASS__)
      Severity: Minor
      Found in src/Library/CommandLine/Helper.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getOptionHelp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getOptionHelp($arg, $caller)
          {
              if (!is_object($caller) || !($caller instanceof CommandLineControllerInterface)) {
                  throw new InvalidArgumentException(
                      sprintf('Argument 2 for method "%s::getOptionHelp" must be an object and implement the "CommandLineControllerInterface" interface!', __CLASS__)
      Severity: Minor
      Found in src/Library/CommandLine/Helper.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function getOptionDescription($arg, $caller)
          {
              if (!is_object($caller) || !($caller instanceof CommandLineControllerInterface)) {
                  throw new InvalidArgumentException(
                      sprintf('Argument 2 for method "%s::getOptionDescription" must be an object and implement the "CommandLineControllerInterface" interface!', __CLASS__)
      Severity: Major
      Found in src/Library/CommandLine/Helper.php and 1 other location - About 5 hrs to fix
      src/Library/CommandLine/Helper.php on lines 114..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 187.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function getOptionHelp($arg, $caller)
          {
              if (!is_object($caller) || !($caller instanceof CommandLineControllerInterface)) {
                  throw new InvalidArgumentException(
                      sprintf('Argument 2 for method "%s::getOptionHelp" must be an object and implement the "CommandLineControllerInterface" interface!', __CLASS__)
      Severity: Major
      Found in src/Library/CommandLine/Helper.php and 1 other location - About 5 hrs to fix
      src/Library/CommandLine/Helper.php on lines 67..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 187.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              foreach($tmp_alias_list as $_meth=>$_options) {
                  $title = str_replace( ':', '', implode('|', $_options) );
                  if (substr_count(implode('|', $_options),'::'))
                      $title .= ' <opt.arg>';
                  elseif (substr_count(implode('|', $_options),':'))
      Severity: Major
      Found in src/Library/CommandLine/Helper.php and 2 other locations - About 2 hrs to fix
      src/Library/CommandLine/Helper.php on lines 167..174
      src/Library/CommandLine/Helper.php on lines 183..190

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              foreach($tmp_options_list as $_meth=>$_options) {
                  $title = str_replace( ':', '', implode('|', $_options) );
                  if (substr_count(implode('|', $_options),'::'))
                      $title .= ' <opt.arg>';
                  elseif (substr_count(implode('|', $_options),':'))
      Severity: Major
      Found in src/Library/CommandLine/Helper.php and 2 other locations - About 2 hrs to fix
      src/Library/CommandLine/Helper.php on lines 183..190
      src/Library/CommandLine/Helper.php on lines 199..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              foreach($tmp_commands_list as $_meth=>$_options) {
                  $title = str_replace( ':', '', implode('|', $_options) );
                  if (substr_count(implode('|', $_options),'::'))
                      $title .= ' <opt.arg>';
                  elseif (substr_count(implode('|', $_options),':'))
      Severity: Major
      Found in src/Library/CommandLine/Helper.php and 2 other locations - About 2 hrs to fix
      src/Library/CommandLine/Helper.php on lines 167..174
      src/Library/CommandLine/Helper.php on lines 199..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status