Sign upLogin

atelierspierrot/library

View on GitHub
Star
src/Library/Router.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function generateUrl has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function generateUrl($route_infos, $base_uri = null, $hash = null, $separator = '&')
    {
        $url_args = $this->getArgumentsMap()->getCollection();

        $url = $base_uri;
Severity: Minor
Found in src/Library/Router.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Router has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class Router
    implements RouterInterface
{

    /**
Severity: Minor
Found in src/Library/Router.php - About 2 hrs to fix

    Function _parseUrl has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _parseUrl()
    {
        $url_frgts = UrlHelper::parse($this->getUrl());
        $route = array('all'=>array());
        if (!empty($url_frgts['params'])) {
    Severity: Minor
    Found in src/Library/Router.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function urlEncode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function urlEncode($str = null, $keep_mask = true)
    {
        if (
            (!empty($str) && is_numeric($str)) ||
            (true===$keep_mask && $str==='%s')
    Severity: Minor
    Found in src/Library/Router.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status