Showing 9 of 10 total issues

Method rest has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function rest($pattern, $model = null, $methods = ['read', 'modify', 'delete'])
    {
        $methods = array_map('strtolower', $methods);

        // GET all records
Severity: Major
Found in src/Api.php - About 2 hrs to fix

    Function rest has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function rest($pattern, $model = null, $methods = ['read', 'modify', 'delete'])
        {
            $methods = array_map('strtolower', $methods);
    
            // GET all records
    Severity: Minor
    Found in src/Api.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method match has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function match($pattern)
        {
            $path = explode('/', rtrim($this->path, '/'));
            $pattern = explode('/', rtrim($pattern, '/'));
    
    
    Severity: Minor
    Found in src/Api.php - About 1 hr to fix

      Method init has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function init()
          {
              parent::init();
              $this->addField('name', ['actual'=>'nicename', 'required'=>true, 'type'=>'string']);
              $this->addField('sys_name', ['actual'=>'name', 'system'=>true]);
      Severity: Minor
      Found in examples/test.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                        return !$model->delete($id)->loaded();
        Severity: Major
        Found in src/Api.php - About 30 mins to fix

          Avoid using static access to class '\Laminas\Diactoros\ServerRequestFactory' in method '__construct'.
          Open

                  $this->request = $request ?: ServerRequestFactory::fromGlobals();
          Severity: Minor
          Found in src/Api.php by phpmd

          Since: PHPMD 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example:

          class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

          Source: http://phpmd.org/rules/cleancode.txt

          The method caughtException() contains an exit expression.
          Open

                  exit;
          Severity: Minor
          Found in src/Api.php by phpmd

          Since: PHPMD 0.2

          An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

          Example:

          class Foo {
                public function bar($param)  {
                    if ($param === 42) {
                        exit(23);
                    }
                }
            }

          Source: http://phpmd.org/rules/design.txt

          The method successResponse() contains an exit expression.
          Open

                      exit;
          Severity: Minor
          Found in src/Api.php by phpmd

          Since: PHPMD 0.2

          An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

          Example:

          class Foo {
                public function bar($param)  {
                    if ($param === 42) {
                        exit(23);
                    }
                }
            }

          Source: http://phpmd.org/rules/design.txt

          TODO found
          Open

              // TODO: think of some logical example here!!
          Severity: Minor
          Found in README.md by fixme
          Severity
          Category
          Status
          Source
          Language