Sign upLogin

atk4/core

View on GitHub
Star
src/Factory.php

Summary

Maintainability
A
0 mins
Test Coverage

The method _mergeSeeds() has an NPath complexity of 2900. The configured NPath complexity threshold is 200.
Open

    protected function _mergeSeeds(...$seeds)
    {
        // merge seeds but prefer seed over seed2
        // move numerical keys to the beginning and sort them
        $arguments = [];
Severity: Minor
Found in src/Factory.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method _mergeSeeds() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
Open

    protected function _mergeSeeds(...$seeds)
    {
        // merge seeds but prefer seed over seed2
        // move numerical keys to the beginning and sort them
        $arguments = [];
Severity: Minor
Found in src/Factory.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Missing class import via use statement (line '195', column '23').
Open

            throw new \Error('Too many method arguments');
Severity: Minor
Found in src/Factory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'Atk4\Core\TraitUtil' in method '_mergeSeeds'.
Open

            if (!TraitUtil::hasDiContainerTrait($obj)) {
Severity: Minor
Found in src/Factory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method _factory uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $seed = $this->_mergeSeeds($seed, $defaults);
        }
Severity: Minor
Found in src/Factory.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$seedIndex'.
Open

        foreach ($seeds as $seedIndex => $seed) {
Severity: Minor
Found in src/Factory.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The property $_instance is not named in camelCase.
Open

class Factory
{
    use WarnDynamicPropertyTrait;

    private static ?Factory $_instance = null;
Severity: Minor
Found in src/Factory.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Method name "_factory" should not be prefixed with an underscore to indicate visibility
Open

    protected function _factory($seed, array $defaults): object
Severity: Minor
Found in src/Factory.php by phpcodesniffer

Property name "$_instance" should not be prefixed with an underscore to indicate visibility
Open

    private static ?Factory $_instance = null;
Severity: Minor
Found in src/Factory.php by phpcodesniffer

Method name "_newObject" should not be prefixed with an underscore to indicate visibility
Open

    protected function _newObject(string $className, array $ctorArgs): object
Severity: Minor
Found in src/Factory.php by phpcodesniffer

Method name "_mergeSeeds" should not be prefixed with an underscore to indicate visibility
Open

    protected function _mergeSeeds(...$seeds)
Severity: Minor
Found in src/Factory.php by phpcodesniffer

Line exceeds 120 characters; contains 129 characters
Open

                throw (new Exception('Property injection is possible only to objects that use Atk4\Core\DiContainerTrait trait'))
Severity: Minor
Found in src/Factory.php by phpcodesniffer

Line exceeds 120 characters; contains 124 characters
Open

        if (!is_array($seed) && !is_object($seed)) { // @phpstan-ignore function.alreadyNarrowedType, booleanAnd.alwaysFalse
Severity: Minor
Found in src/Factory.php by phpcodesniffer

The method _factory is not named in camelCase.
Open

    protected function _factory($seed, array $defaults): object
    {
        if (!is_array($seed) && !is_object($seed)) { // @phpstan-ignore function.alreadyNarrowedType, booleanAnd.alwaysFalse
            throw new Exception('Use of non-array (' . gettype($seed) . ') seed is not supported');
        }
Severity: Minor
Found in src/Factory.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _mergeSeeds is not named in camelCase.
Open

    protected function _mergeSeeds(...$seeds)
    {
        // merge seeds but prefer seed over seed2
        // move numerical keys to the beginning and sort them
        $arguments = [];
Severity: Minor
Found in src/Factory.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _newObject is not named in camelCase.
Open

    protected function _newObject(string $className, array $ctorArgs): object
    {
        return new $className(...$ctorArgs);
    }
Severity: Minor
Found in src/Factory.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status