Sign upLogin

atk4/data

View on GitHub
Star
src/Persistence/Sql/Connection.php

Summary

Maintainability
D
1 day
Test Coverage

Function normalizeDsn has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public static function normalizeDsn($dsn, $user = null, $password = null)
    {
        // BC for 2.4 - 3.0 accepted DSN input
        if (is_string($dsn)) {
            $dsn = ['dsn' => $dsn];
Severity: Minor
Found in src/Persistence/Sql/Connection.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Connection has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Connection
{
    use DiContainerTrait;

    /** @var class-string<Expression> */
Severity: Minor
Found in src/Persistence/Sql/Connection.php - About 2 hrs to fix

Method normalizeDsn has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function normalizeDsn($dsn, $user = null, $password = null)
    {
        // BC for 2.4 - 3.0 accepted DSN input
        if (is_string($dsn)) {
            $dsn = ['dsn' => $dsn];
Severity: Major
Found in src/Persistence/Sql/Connection.php - About 2 hrs to fix

File Connection.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Atk4\Data\Persistence\Sql;
Severity: Minor
Found in src/Persistence/Sql/Connection.php - About 2 hrs to fix

There are no issues that match your filters.

Category
Status