Showing 43 of 49 total issues
Function _render_table
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
protected function _render_table($add_alias = true): ?string
{
// will be joined for output
$ret = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method consume
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function consume($expression, string $escapeMode = self::ESCAPE_PARAM)
{
if (!is_object($expression)) {
switch ($escapeMode) {
case self::ESCAPE_PARAM:
Method connectDbalConnection
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected static function connectDbalConnection(array $dsn)
{
// for some reasons, the following error:
// PDOException: SQLSTATE[HY000]: pdo_oci_handle_factory: ORA-12516: TNS:listener could not find available handler with matching protocol stack
// is shown randomly when a lot of connections are created in tests,
Function _render_field
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
protected function _render_field($add_alias = true): string
{
// will be joined for output
$ret = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method order
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function order($order, $desc = null)
{
// Case with comma-separated fields or first argument being an array
if (is_string($order) && strpos($order, ',') !== false) {
$order = explode(',', $order);
Method _render_case
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _render_case(): ?string
{
if (!isset($this->args['case_when'])) {
return null;
}
Method getUpdateExtendedPropertySQL
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
$name,
$value = null,
$level0Type = null,
$level0Name = null,
$level1Type = null,
Method getAddExtendedPropertySQL
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
$name,
$value = null,
$level0Type = null,
$level0Name = null,
$level1Type = null,
Function connectDbalConnection
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
protected static function connectDbalConnection(array $dsn)
{
if (isset($dsn['pdo'])) {
$pdo = $dsn['pdo'];
} else {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getDropExtendedPropertySQL
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
$name,
$level0Type = null,
$level0Name = null,
$level1Type = null,
$level1Name = null,
Method where
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function where($field, $cond = null, $value = null, $kind = 'where', $num_args = null)
Function __construct
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function __construct($properties = [], $arguments = null)
{
// save template
if (is_string($properties)) {
$properties = ['template' => $properties];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function set
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function set($field, $value = null)
{
if (is_array($value)) {
throw (new Exception('Array values are not supported by SQL'))
->addMoreInfo('field', $field)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function field
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function field($field, $alias = null)
{
// field is passed as string, may contain commas
if (is_string($field) && strpos($field, ',') !== false) {
$field = explode(',', $field);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _render_join
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function _render_join(): ?string
{
if (!isset($this->args['join'])) {
return '';
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function normalizeDsn
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public static function normalizeDsn($dsn, $user = null, $pass = null)
{
// Try to dissect DSN into parts
$parts = is_array($dsn) ? $dsn : parse_url($dsn);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return '1 = 1'; // always true
Avoid too many return
statements within this method. Open
return $field . ' ' . $cond . ' ' . $value;
Avoid too many return
statements within this method. Open
$value = '(' . implode(', ', array_map(function ($v) { return $this->escapeParam($v); }, $value)) . ')';
Avoid too many return
statements within this method. Open
return $ret;