The method saveJsCoverage() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
protected function saveJsCoverage(): void
{
if (!$this->isJsCoverageEnabled()) {
return;
}- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '97', column '35'). Open
throw new \Exception('Unexpected JS coverage hash change');- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method saveJsCoverage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($this->jsCoverage[$path]['hash'] !== $data['hash']
|| $this->jsCoverage[$path]['_coverageSchema'] !== $data['_coverageSchema']
|| count($this->jsCoverage[$path]['s']) !== count($data['s'])
|| count($this->jsCoverage[$path]['f']) !== count($data['f'])- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method saveJsCoverage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->jsCoverage[$path][$k][$i] += $n;
}- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 12 and the first side effect is on line 7. Open
<?php- Create a ticketCreate a ticket
- Exclude checks
Possible parse error: trait missing opening or closing brace Open
trait JsCoverageContextTrait- Create a ticketCreate a ticket
- Exclude checks
Possible parse error: trait missing opening or closing brace Open
trait JsCoverageContextTrait- Create a ticketCreate a ticket
- Exclude checks
Line exceeds 120 characters; contains 125 characters Open
const navigateCoverages = JSON.parse(window.sessionStorage.getItem('__coverage_navigate__') ?? '[]');- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
}- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
private array $jsCoverage = [];- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 0 spaces, found 8 Open
}- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 0 spaces, found 8 Open
if (!$this->isJsCoverageEnabled()) {- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
protected function isJsCoverageEnabled(): bool- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
}- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
if (!$this->isJsCoverageEnabled()) {- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
public function __destruct()- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
protected function saveJsCoverage(): void- Create a ticketCreate a ticket
- Exclude checks
Line indented incorrectly; expected 0 spaces, found 4 Open
}- Create a ticketCreate a ticket
- Exclude checks