Sign upLogin

atk4/ui

View on GitHub
Star
src/Form/Control/ScopeBuilder.php

Summary

Maintainability
A
0 mins
Test Coverage

The class ScopeBuilder has an overall complexity of 71 which is very high. The configured complexity threshold is 50.
Open

class ScopeBuilder extends Form\Control
{
    public $renderLabel = false;

    /** @var array<string, array<string, mixed>|bool> */
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

The method queryToCondition() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
Open

    public function queryToCondition(array $query): Condition
    {
        $key = $query['rule'];
        $operator = $query['operator'];
        $value = $query['value'];
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method addFieldRule uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $type = $field->type;
        }
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method conditionToQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            throw (new Exception('Unsupported scope field type'))
                ->addMoreInfo('field', $condition->field);
        }
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Atk4\Ui\View' in method 'init'.
Open

        $this->scopeBuilderView = View::addTo($this, ['template' => $this->scopeBuilderTemplate]);
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method conditionToQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if (is_array($value)) {
                $map = [
                    Condition::OPERATOR_EQUALS => Condition::OPERATOR_IN,
                    Condition::OPERATOR_DOESNOT_EQUAL => Condition::OPERATOR_NOT_IN,
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method buildQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $scope = $model->scope();
        }
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$form'.
Open

            $this->form->onHook(Form::HOOK_LOAD_POST, function (Form $form, array &$postRawData) {
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid variables with short names like $v. Configured minimum length is 3.
Open

                $components = array_map(fn ($v) => $this->queryToScope($v), $query['query']['children']);
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Line exceeds 120 characters; contains 128 characters
Open

                'labels' => $this->labels !== [] ? $this->labels : null, // TODO do we need to really pass null for empty array?
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpcodesniffer

Line exceeds 120 characters; contains 145 characters
Open

            $this->scopeBuilderTemplate = new HtmlTemplate('<div {$attributes}><atk-query-builder v-bind="initData"></atk-query-builder></div>');
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpcodesniffer

Line exceeds 120 characters; contains 128 characters
Open

     * Auto-detects a string delimiter based on list of predefined values in ScopeBuilder::$listDelimiters in order of priority.
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpcodesniffer

Space before opening parenthesis of function call prohibited
Open

                $components = array_map(fn ($v) => $this->queryToScope($v), $query['query']['children']);
Severity: Minor
Found in src/Form/Control/ScopeBuilder.php by phpcodesniffer

There are no issues that match your filters.

Category
Status