Sign upLogin

atk4/ui

View on GitHub
Star
src/Form/Layout/Custom.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Atk4\Core\Factory' in method 'addButton'.
Open

        return $this->add(Factory::mergeSeeds([Button::class], $seed), 'Buttons');
Severity: Minor
Found in src/Form/Layout/Custom.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Line exceeds 120 characters; contains 146 characters
Open

            throw new Exception('You must specify template for Form/Layout/Custom. Try [\'Custom\', \'defaultTemplate\' => \'./yourform.html\']');
Severity: Minor
Found in src/Form/Layout/Custom.php by phpcodesniffer

There are no issues that match your filters.

Category
Status