Sign upLogin

atk4/ui

View on GitHub
Star
src/Js/JsChain.php

Summary

Maintainability
A
0 mins
Test Coverage

The method jsRender uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $name = $chain[0];
                $args = $chain[1];
            }
Severity: Minor
Found in src/Js/JsChain.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The property $_constructorArgs is not named in camelCase.
Open

class JsChain extends JsExpression
{
    public string $_library;

    /**
Severity: Minor
Found in src/Js/JsChain.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $_chain is not named in camelCase.
Open

class JsChain extends JsExpression
{
    public string $_library;

    /**
Severity: Minor
Found in src/Js/JsChain.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $_library is not named in camelCase.
Open

class JsChain extends JsExpression
{
    public string $_library;

    /**
Severity: Minor
Found in src/Js/JsChain.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Property name "$_library" should not be prefixed with an underscore to indicate visibility
Open

    public string $_library;
Severity: Minor
Found in src/Js/JsChain.php by phpcodesniffer

Property name "$_constructorArgs" should not be prefixed with an underscore to indicate visibility
Open

    public $_constructorArgs = [];
Severity: Minor
Found in src/Js/JsChain.php by phpcodesniffer

Method name "_renderArgs" should not be prefixed with an underscore to indicate visibility
Open

    private function _renderArgs(array $args = []): string
Severity: Minor
Found in src/Js/JsChain.php by phpcodesniffer

Property name "$_chain" should not be prefixed with an underscore to indicate visibility
Open

    public $_chain = [];
Severity: Minor
Found in src/Js/JsChain.php by phpcodesniffer

The method _renderArgs is not named in camelCase.
Open

    private function _renderArgs(array $args = []): string
    {
        return '('
            . implode(', ', array_map(function ($arg) {
                return $this->_jsEncode($arg);
Severity: Minor
Found in src/Js/JsChain.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status