Sign upLogin

atk4/ui

View on GitHub
Star
src/Js/JsExpression.php

Summary

Maintainability
A
0 mins
Test Coverage

The method _jsEncode() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
Open

    protected function _jsEncode($value): string
    {
        if ($value instanceof JsExpressionable) {
            $res = $value->jsRender();
        } elseif ($value instanceof View) {
Severity: Minor
Found in src/Js/JsExpression.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method _jsEncode uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $res = '[' . implode(', ', $array) . ']';
            }
Severity: Minor
Found in src/Js/JsExpression.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method _jsEncode uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            throw (new Exception('Argument is not renderable to JS'))
                ->addMoreInfo('arg', $value);
        }
Severity: Minor
Found in src/Js/JsExpression.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method _jsEncode uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $array[] = $k . ': ' . $v;
                }
Severity: Minor
Found in src/Js/JsExpression.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Atk4\Data\Persistence\Sql\Expression' in method '_jsEncode'.
Open

            $res = Persistence\Sql\Expression::castFloatToString($value);
Severity: Minor
Found in src/Js/JsExpression.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Method name "_jsEncode" should not be prefixed with an underscore to indicate visibility
Open

    protected function _jsEncode($value): string
Severity: Minor
Found in src/Js/JsExpression.php by phpcodesniffer

The method _jsEncode is not named in camelCase.
Open

    protected function _jsEncode($value): string
    {
        if ($value instanceof JsExpressionable) {
            $res = $value->jsRender();
        } elseif ($value instanceof View) {
Severity: Minor
Found in src/Js/JsExpression.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status