Sign upLogin

atk4/ui

View on GitHub
Star
src/Js/JsReload.php

Summary

Maintainability
A
35 mins
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(View $view, array $args = [], ?JsExpressionable $afterSuccess = null, array $apiConfig = [], bool $includeStorage = false)
Severity: Minor
Found in src/Js/JsReload.php - About 35 mins to fix

The method __construct has a boolean flag argument $includeStorage, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct(View $view, array $args = [], ?JsExpressionable $afterSuccess = null, array $apiConfig = [], bool $includeStorage = false)
Severity: Minor
Found in src/Js/JsReload.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Line exceeds 120 characters; contains 154 characters
Open

    public function __construct(View $view, array $args = [], ?JsExpressionable $afterSuccess = null, array $apiConfig = [], bool $includeStorage = false)
Severity: Minor
Found in src/Js/JsReload.php by phpcodesniffer

There are no issues that match your filters.

Category
Status