Sign upLogin

atk4/ui

View on GitHub
Star
src/Persistence/Ui.php

Summary

Maintainability
A
0 mins
Test Coverage

The class Ui has an overall complexity of 68 which is very high. The configured complexity threshold is 50.
Open

class Ui extends Persistence
{
    /** @var string */
    public $locale = 'en';
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

The method _typecastLoadField() has an NPath complexity of 1284. The configured NPath complexity threshold is 200.
Open

    protected function _typecastLoadField(Field $field, $value)
    {
        switch ($field->type) {
            case 'boolean':
                if (is_string($value)) {
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method _typecastLoadField() has 105 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    protected function _typecastLoadField(Field $field, $value)
    {
        switch ($field->type) {
            case 'boolean':
                if (is_string($value)) {
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

The method _typecastSaveField() has an NPath complexity of 304. The configured NPath complexity threshold is 200.
Open

    protected function _typecastSaveField(Field $field, $value): ?string
    {
        // always normalize string EOL
        if (is_string($value)) {
            $value = preg_replace('~\r?\n|\r~', "\n", $value);
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method _typecastLoadField() has a Cyclomatic Complexity of 37. The configured cyclomatic complexity threshold is 10.
Open

    protected function _typecastLoadField(Field $field, $value)
    {
        switch ($field->type) {
            case 'boolean':
                if (is_string($value)) {
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method _typecastSaveField() has a Cyclomatic Complexity of 23. The configured cyclomatic complexity threshold is 10.
Open

    protected function _typecastSaveField(Field $field, $value): ?string
    {
        // always normalize string EOL
        if (is_string($value)) {
            $value = preg_replace('~\r?\n|\r~', "\n", $value);
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Missing class import via use statement (line '161', column '38').
Open

                        $value = new \DateTime($value->format('Y-m-d H:i:s.u'), $value->getTimezone());
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '162', column '49').
Open

                        $value->setTimezone(new \DateTimeZone($this->timezone));
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\Atk4\Data\Persistence\Sql\Expression' in method '_typecastSaveField'.
Open

                    : Expression::castFloatToString($value);
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid excessively long variable names like $formatHasMicroseconds. Keep variable name length under 20.
Open

                    $formatHasMicroseconds = str_contains($format, '.u');
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid variables with short names like $no. Configured minimum length is 3.
Open

    public $no = 'No';
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid classes with short names like Ui. Configured minimum length is 3.
Open

class Ui extends Persistence
{
    /** @var string */
    public $locale = 'en';
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

ShortClassName

Since: 2.9

Detects when classes or interfaces have a very short name.

Example

class Fo {

}

interface Fo {

}

Source https://phpmd.org/rules/naming.html#shortclassname

Method name "_typecastLoadField" should not be prefixed with an underscore to indicate visibility
Open

    protected function _typecastLoadField(Field $field, $value)
Severity: Minor
Found in src/Persistence/Ui.php by phpcodesniffer

Method name "_typecastSaveField" should not be prefixed with an underscore to indicate visibility
Open

    protected function _typecastSaveField(Field $field, $value): ?string
Severity: Minor
Found in src/Persistence/Ui.php by phpcodesniffer

Line exceeds 120 characters; contains 124 characters
Open

        $attributePersistence->datetimeFormat = $attributePersistence->dateFormat . ' ' . $attributePersistence->timeFormat;
Severity: Minor
Found in src/Persistence/Ui.php by phpcodesniffer

Line exceeds 120 characters; contains 143 characters
Open

                $value = $dtClass::createFromFormat('!' . $format, $value, $field->type === 'datetime' ? new $tzClass($this->timezone) : null);
Severity: Minor
Found in src/Persistence/Ui.php by phpcodesniffer

Line exceeds 120 characters; contains 142 characters
Open

                    . number_format($value, max($this->currencyDecimals, $valueDecimals), $this->decimalSeparator, $this->thousandsSeparator);
Severity: Minor
Found in src/Persistence/Ui.php by phpcodesniffer

Line exceeds 120 characters; contains 147 characters
Open

                $valueDecimals = strlen(preg_replace('~^[^.]$|^.+\.|0+$~s', '', number_format($value, max(0, 11 - (int) log10($value)), '.', '')));
Severity: Minor
Found in src/Persistence/Ui.php by phpcodesniffer

Line exceeds 120 characters; contains 129 characters
Open

                    if ($field->type === 'atk4_money' && $this->currency !== '' && substr_count($value, $this->currency) === 1) {
Severity: Minor
Found in src/Persistence/Ui.php by phpcodesniffer

The method _typecastSaveField is not named in camelCase.
Open

    protected function _typecastSaveField(Field $field, $value): ?string
    {
        // always normalize string EOL
        if (is_string($value)) {
            $value = preg_replace('~\r?\n|\r~', "\n", $value);
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _typecastLoadField is not named in camelCase.
Open

    protected function _typecastLoadField(Field $field, $value)
    {
        switch ($field->type) {
            case 'boolean':
                if (is_string($value)) {
Severity: Minor
Found in src/Persistence/Ui.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status