Sign upLogin

atk4/ui

View on GitHub
Star
src/UserAction/ExecutorFactory.php

Summary

Maintainability
A
0 mins
Test Coverage

The method registerCaption has a boolean flag argument $isSpecific, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function registerCaption(UserAction $action, string $caption, bool $isSpecific = false, ?string $type = null): void
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method registerTrigger has a boolean flag argument $isSpecific, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function registerTrigger(string $type, $seed, UserAction $action, bool $isSpecific = false): void
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method createExecutor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $seed = (!$action->args && !$action->fields && !$action->preview)
                            ? $this->executorSeed[self::JS_EXECUTOR]
                            : $this->executorSeed[self::STEP_EXECUTOR];
                }
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method registerCaption uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->triggerCaption[$action->shortName] = $caption;
        }
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method createExecutor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $seed = $this->executorSeed[$this->getModelKey($action)][$action->shortName] ?? null;
            if ($seed === null) {
                // if no type is register, determine executor to use base on action properties
                if ($action->confirmation instanceof \Closure) {
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Atk4\Core\Factory' in method 'createActionTrigger'.
Open

        return Factory::factory($seed);
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method registerTrigger uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->triggerSeed[$type][$action->shortName] = $seed;
        }
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Atk4\Core\Factory' in method 'createExecutor'.
Open

        $executor = $owner->add(Factory::factory($seed));
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Line exceeds 120 characters; contains 126 characters
Open

    public function registerCaption(UserAction $action, string $caption, bool $isSpecific = false, ?string $type = null): void
Severity: Minor
Found in src/UserAction/ExecutorFactory.php by phpcodesniffer

There are no issues that match your filters.

Category
Status