atlassian/localstack

View on GitHub
localstack/services/apigateway/apigateway_listener.py

Summary

Maintainability
C
1 day
Test Coverage

Function update_apigateway has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

def update_apigateway(method, path, data, headers, response=None, return_forward_info=False):
    if return_forward_info:

        regex2 = r'^/restapis/([A-Za-z0-9_\-]+)/([A-Za-z0-9_\-]+)/%s/(.*)$' % PATH_USER_REQUEST
        if re.match(regex2, path):
Severity: Minor
Found in localstack/services/apigateway/apigateway_listener.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_apigateway has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def update_apigateway(method, path, data, headers, response=None, return_forward_info=False):
Severity: Minor
Found in localstack/services/apigateway/apigateway_listener.py - About 45 mins to fix

    Avoid too many return statements within this function.
    Open

                        return make_error(msg, 404)
    Severity: Major
    Found in localstack/services/apigateway/apigateway_listener.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return result
      Severity: Major
      Found in localstack/services/apigateway/apigateway_listener.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return 200
        Severity: Major
        Found in localstack/services/apigateway/apigateway_listener.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return True
          Severity: Major
          Found in localstack/services/apigateway/apigateway_listener.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return make_error(msg, 404)
            Severity: Major
            Found in localstack/services/apigateway/apigateway_listener.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return handle_authorizers(method, path, data, headers)
              Severity: Major
              Found in localstack/services/apigateway/apigateway_listener.py - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status